Public tactics#791
Merged
frankmcsherry merged 1 commit intoJul 8, 2026
Merged
Conversation
frankmcsherry
added a commit
to frankmcsherry/differential-dataflow
that referenced
this pull request
Jul 9, 2026
…low#791 pub); port ProxyJoinTactic to `prep` master-next reshaped `JoinTactic` from `defer`+fuel-metered `work` to a single `prep(input0, input1, fresh, meet) -> Box<dyn Iterator<Item = C>>` (TimelyDataflow#790), with the driver now owning the queues, capabilities, and fuel; and flipped the tactics to `pub` (TimelyDataflow#791). `operators/join.rs` resolves to master-next's version (our only change there was the same pub flip); `operators/reduce.rs` auto-merged. Port `ProxyJoinTactic` to the new trait: - The tactic is now pure data-to-data: `prep` maps two batch lists to output container(s), holding no queues/capabilities/fuel. Dropped `JoinUnit`, the two queues, and `defer`/`work`; `join_unit` becomes `join_prep` returning `Option<Bk::Output>`. `meet` (the driver-supplied capability time) feeds `JoinInstance.lower` directly. - This is the eager port: `prep` returns the whole unit's output as one container (`iter::once`). Correct and behaviour-preserving; the F8 fuel footgun is gone structurally (the driver meters fuel now). Making `prep` lazy/windowed is F9's join half — see the updated F8/F9. - Tests: `join_with_tactic` turbofish now takes the container `C`, not the builder. Full workspace green (incl. SCC/BFS and the int_proxy suite, 14 tests). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flips the
pub(crate)on tactics topub, which should open them up for use.