Fixed /github-search command failing in some cases#1435
Open
Fixed /github-search command failing in some cases#1435
Conversation
|
firasrg
reviewed
Mar 11, 2026
| List<String> choices = Stream.generate(closestSuggestions::poll).limit(25).toList(); | ||
| event.replyChoiceStrings(choices).queue(); | ||
| if (choices.isEmpty()) { | ||
| choices = List.of("no issue found"); |
Contributor
There was a problem hiding this comment.
If this expression is supposed to be shown on UI, I believe it should start with Uppercase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What looks inoccent in the code
reference.findIssue(...)is actually running API queries in the background. So it is not a quick command.The code apparently overlooked this and did not make use of JDAs
event.deferReply().queue(). In many cases this then leads to the action crashing because it takes longer than 3 seconds:This fixes the code by properly using
deferReplyand then responding through theInteractionHook.While at it, the PR also fixes a bug with the code in the edge case that the configured GitHub repos have no issues yet (or more commonly when a
githubApiKeyhas not been set up yet). In this case the autocompletion code crashed because it was supplying an empty list. This is now fixed by supplyingno issues foundin that edge case.