fix(worker): sample action peak memory by process group#2409
Merged
amankrx merged 1 commit intoJun 9, 2026
Merged
Conversation
|
Someone is attempting to deploy a commit to the native-link-web-assets Team on Vercel. A member of the Team first needs to authorize it. |
|
|
amankrx
force-pushed
the
fix/action-resource-usage-sampler-reparenting
branch
2 times, most recently
from
6095584 to
b0fb22f
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
palfrey
requested changes
Jun 9, 2026
amankrx
force-pushed
the
fix/action-resource-usage-sampler-reparenting
branch
2 times, most recently
from
7de975b to
656bdbc
Compare
The action-resource-usage sampler walked the spawned child's process subtree (/proc/<pid>/task/*/children) to sum RSS. When an intermediate shell exits and reparents the real workload to the worker (PID 1), the spawned child is left a childless zombie, so the walk reports 0. The worker then omits ActionResourceUsage (gated on peak_memory_kb > 0), no ResponseEvent.ActionResourceUsage origin event is published, and execution_tasks.observed_worker_peak_memory_mib stays NULL. Spawn the action as its own process-group leader and sum RSS of every process whose pgrp == pgid instead. Process-group membership is inherited and survives reparenting, and excludes the worker's own group.
amankrx
force-pushed
the
fix/action-resource-usage-sampler-reparenting
branch
from
656bdbc to
b485898
Compare
palfrey
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The action-resource-usage sampler walked the spawned child's process subtree (/proc//task/*/children) to sum RSS. When an intermediate shell exits and reparents the real workload to the worker (PID 1), the spawned child is left a childless zombie, so the walk reports 0. The worker then omits ActionResourceUsage (gated on peak_memory_kb > 0), no ResponseEvent.ActionResourceUsage origin event is published, and execution_tasks.observed_worker_peak_memory_mib stays NULL.
Spawn the action as its own process-group leader and sum RSS of every process whose pgrp == pgid instead. Process-group membership is inherited and survives reparenting, and excludes the worker's own group.
Type of change
Please delete options that aren't relevant.
How Has This Been Tested?
Tested with local on prem test
Checklist
bazel test //...passes locallygit amendsee some docsThis change is