Conversation
They explained the address-role rule three times over. Keep the reason, drop the retelling.
Collaborator
Author
|
Comment-only; not worth a release cycle on its own. Will fold into the next substantive tap-go change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment-only. The doc comments on
Validate,addressRoleand the role constants each restated the address-role rule in full; one statement of the reason is enough.Also corrects the claim that roles are "free-form strings" — TAIP-5's prose allows an array, but its JSON schema and TypeScript types do not, which is why
Rolestays a string.