Skip to content

Fixed stale Ghost-CLI update checks in CI#28556

Draft
9larsons wants to merge 1 commit into
mainfrom
codex/skip-invalid-ghost-cli-upgrade-test
Draft

Fixed stale Ghost-CLI update checks in CI#28556
9larsons wants to merge 1 commit into
mainfrom
codex/skip-invalid-ghost-cli-upgrade-test

Conversation

@9larsons

@9larsons 9larsons commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • skip the Ghost-CLI latest-release update check when the CI archive cannot upgrade the installed latest release
  • keep the archive clean-install check running so PR tarball coverage remains intact
  • document the stale-PR-after-release case inline in the workflow

Context

The failing run was a PR event from a fork branch named main, not a push to TryGhost/Ghost's main. Its tarball was built as 6.45.0-rc.0, but npm latest had already moved to 6.45.0, so ghost update --archive correctly rejected the archive as a downgrade.

This can happen for any stale PR after a release, not only fork PRs. Checking whether the archive can actually upgrade the installed latest release matches the Ghost-CLI invariant and avoids hiding the clean-install coverage for PR artifacts.

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 23bdf24d-edf2-41e5-8edd-ef80d7419f68

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/skip-invalid-ghost-cli-upgrade-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud

nx-cloud Bot commented Jun 12, 2026

Copy link
Copy Markdown

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit 7d6279c

Command Status Duration Result
nx run @tryghost/admin-x-settings:test:acceptance ✅ Succeeded 10m 15s View ↗
nx run ghost:test:ci:integration:no-coverage ✅ Succeeded 1m 48s View ↗
nx run ghost:test:ci:integration ✅ Succeeded 1m 6s View ↗
nx run ghost:test:ci:e2e:no-coverage ✅ Succeeded 3m 49s View ↗
nx run ghost:test:ci:e2e ✅ Succeeded 3m 44s View ↗
nx run ghost:test:ci:legacy ✅ Succeeded 2m 18s View ↗
nx build @tryghost/announcement-bar ✅ Succeeded <1s View ↗
nx build @tryghost/sodo-search ✅ Succeeded <1s View ↗
Additional runs (15) ✅ Succeeded ... View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-06-12 19:11:34 UTC

ref https://github.com/TryGhost/Ghost/actions/runs/27363373050/job/81093946714

- PR artifacts can carry a prerelease version that is older than the current npm latest after a release lands, so the Ghost-CLI update path can report a false downgrade failure

- keep the archive clean-install coverage for every run, but skip only the latest-release update check when the archive is not newer than the installed latest release
@9larsons 9larsons force-pushed the codex/skip-invalid-ghost-cli-upgrade-test branch from 7d6279c to f9e9232 Compare June 12, 2026 18:57
@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.76%. Comparing base (8f22426) to head (f9e9232).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #28556   +/-   ##
=======================================
  Coverage   73.76%   73.76%           
=======================================
  Files        1541     1541           
  Lines      132252   132252           
  Branches    15852    15852           
=======================================
  Hits        97557    97557           
  Misses      33730    33730           
  Partials      965      965           
Flag Coverage Δ
e2e-tests 75.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant