Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/job-manager/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"@breejs/later": "4.2.0",
"@tryghost/errors": "^1.3.8",
"@tryghost/logging": "^2.5.0",
"bree": "6.5.0",
"bree": "9.2.7",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bree upgrade breaks tests due to Maps instead of objects

Upgrading bree from 6.5.0 to 9.2.7 introduces a breaking change from v8.0.0 where workers, timeouts, and intervals were refactored from plain objects to Map instances. The existing test code accesses these properties using bracket notation (e.g., bree.workers['job-name']) and Object.keys(), which will return undefined and [] respectively when used on Maps. This will cause test failures as the tests verify critical JobManager behavior. The tests need to be updated to use Map methods like .get() and .keys() instead of object property access patterns.

Fix in Cursor Fix in Web

"cron-validate": "1.4.5",
"fastq": "1.20.1",
"p-wait-for": "3.2.0",
Expand Down
80 changes: 16 additions & 64 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -672,7 +672,7 @@
dependencies:
"@babel/helper-plugin-utils" "^7.27.1"

"@babel/runtime@^7.10.5", "@babel/runtime@^7.12.5", "@babel/runtime@^7.21.0":
"@babel/runtime@^7.10.5", "@babel/runtime@^7.21.0":
version "7.28.4"
resolved "https://registry.yarnpkg.com/@babel/runtime/-/runtime-7.28.4.tgz#a70226016fabe25c5783b2f22d3e1c9bc5ca3326"
integrity sha512-Q/N6JNWvIvPnLDvjlE1OUBLPQHH6l3CltCEsHIujp45zQUSSh8K+gHnaEX45yAT1nyngnINhvWtzN+Nb9D8RAQ==
Expand Down Expand Up @@ -717,7 +717,7 @@
resolved "https://registry.yarnpkg.com/@bcoe/v8-coverage/-/v8-coverage-1.0.2.tgz#bbe12dca5b4ef983a0d0af4b07b9bc90ea0ababa"
integrity sha512-6zABk/ECA/QYSCQ1NGiVwwbQerUCZ+TQbp64Q3AgmfNvurHH0j8TtXa1qbShXA6qqkpAj4V5W8pP6mLe1mcMqA==

"@breejs/[email protected]", "@breejs/later@^4.1.0":
"@breejs/[email protected]", "@breejs/later@^4.2.0":
version "4.2.0"
resolved "https://registry.yarnpkg.com/@breejs/later/-/later-4.2.0.tgz#669661f3a02535ef900f360c74e48c3f5483c786"
integrity sha512-EVMD0SgJtOuFeg0lAVbCwa+qeTKILb87jqvLyUtQswGD9+ce2nB52Y5zbTF1Hc0MDFfbydcMcxb47jSdhikVHA==
Expand Down Expand Up @@ -3418,11 +3418,6 @@ body-parser@~1.20.3:
type-is "~1.6.18"
unpipe "~1.0.0"

boolean@^3.0.2:
version "3.2.0"
resolved "https://registry.yarnpkg.com/boolean/-/boolean-3.2.0.tgz#9e5294af4e98314494cbb17979fa54ca159f116b"
integrity sha512-d0II/GO9uf9lfUHH2BQsjxzRJZBdsjgsBiW4BvhWk/3qoKwQFjIDVN19PfX8F2D/r9PCMTtLWjYVCFrpeYUzsw==

bowser@^2.11.0:
version "2.13.1"
resolved "https://registry.yarnpkg.com/bowser/-/bowser-2.13.1.tgz#5a4c652de1d002f847dd011819f5fc729f308a7e"
Expand Down Expand Up @@ -3450,23 +3445,18 @@ braces@^3.0.3, braces@~3.0.2:
dependencies:
fill-range "^7.1.1"

bree@6.5.0:
version "6.5.0"
resolved "https://registry.yarnpkg.com/bree/-/bree-6.5.0.tgz#f7aeb2d65c2837a733edb6c93d1f354643942e27"
integrity sha512-Yzoflt/zwaRQeF1Gurjbn0g49kZ9QTA7rWR0IKQliKiUJSrsuGbtyBToI5WV60dmd+SEVPtu0oJCjYbEeduYyw==
bree@9.2.7:
version "9.2.7"
resolved "https://registry.yarnpkg.com/bree/-/bree-9.2.7.tgz#cd7d7a13b1c4905715b84c16cdf76d4b06700762"
integrity sha512-17qZng7m7mT7X8hf8hKSOtj/vMsk9+J+u3XtSr3jU2PkY/4N1Xy8OAd7P6j65zOcYM+4Q8pOG42UEnZlMlO0kQ==
dependencies:
"@babel/runtime" "^7.12.5"
"@breejs/later" "^4.1.0"
boolean "^3.0.2"
bthreads "^0.5.1"
"@breejs/later" "^4.2.0"
combine-errors "^3.0.3"
cron-validate "^1.4.1"
debug "^4.3.1"
human-interval "^2.0.0"
is-string-and-not-blank "^0.0.2"
is-valid-path "^0.1.1"
ms "^2.1.2"
p-wait-for "3.1.0"
cron-validate "^1.5.3"
human-interval "^2.0.1"
is-invalid-path "^0.1.0"
ms "^2.1.3"
p-wait-for "3"
safe-timers "^1.1.0"

broccoli-debug@^0.6.5:
Expand Down Expand Up @@ -3599,13 +3589,6 @@ [email protected]:
dependencies:
node-int64 "^0.4.0"

bthreads@^0.5.1:
version "0.5.1"
resolved "https://registry.yarnpkg.com/bthreads/-/bthreads-0.5.1.tgz#c7a4dacc2d159c50de08b37b1e2a7da836171063"
integrity sha512-nK7Jo9ll+r1FRMNPWEFRTZMQrX6HhX8JjPAofxmbTNILHqWVIJPmWzCi9JlX/K0DL5AKZTFZg2Qser5C6gVs9A==
dependencies:
bufio "~1.0.5"

buffer-crc32@^0.2.1, buffer-crc32@^0.2.13, buffer-crc32@~0.2.3:
version "0.2.13"
resolved "https://registry.yarnpkg.com/buffer-crc32/-/buffer-crc32-0.2.13.tgz#0d333e3f00eac50aa1454abd30ef8c2a5d9a7242"
Expand All @@ -3624,11 +3607,6 @@ buffer@^5.5.0:
base64-js "^1.3.1"
ieee754 "^1.1.13"

bufio@~1.0.5:
version "1.0.7"
resolved "https://registry.yarnpkg.com/bufio/-/bufio-1.0.7.tgz#b7f63a1369a0829ed64cc14edf0573b3e382a33e"
integrity sha512-bd1dDQhiC+bEbEfg56IdBv7faWa6OipMs/AFFFvtFnB3wAYjlwQpQRZ0pm6ZkgtfL0pILRXhKxOiQj6UzoMR7A==

builtin-modules@^3.3.0:
version "3.3.0"
resolved "https://registry.yarnpkg.com/builtin-modules/-/builtin-modules-3.3.0.tgz#cae62812b89801e9656336e46223e030386be7b6"
Expand Down Expand Up @@ -4123,7 +4101,7 @@ [email protected]:
dependencies:
yup "0.32.9"

cron-validate@^1.4.1:
cron-validate@^1.5.3:
version "1.5.3"
resolved "https://registry.yarnpkg.com/cron-validate/-/cron-validate-1.5.3.tgz#cf2d6aad35692dee1e7338995e638ad0f0d981ab"
integrity sha512-jcu8g/3wZL8OBr4MkEcbeIdLpM8pp5Y6UoOlRktcJG3WjgpifijR0s26Yac7ywR0gC2ABtevOsz5mlD3l3gzwA==
Expand Down Expand Up @@ -5961,7 +5939,7 @@ https-proxy-agent@^5.0.0:
agent-base "6"
debug "4"

human-interval@^2.0.0:
human-interval@^2.0.1:
version "2.0.1"
resolved "https://registry.yarnpkg.com/human-interval/-/human-interval-2.0.1.tgz#655baf606c7067bb26042dcae14ec777b099af15"
integrity sha512-r4Aotzf+OtKIGQCB3odUowy4GfUDTy3aTWTfLd7ZF2gBCy3XW3v/dJLRefZnOFFnjqs5B1TypvS8WarpBkYUNQ==
Expand Down Expand Up @@ -6271,18 +6249,6 @@ is-shared-array-buffer@^1.0.4:
dependencies:
call-bound "^1.0.3"

is-string-and-not-blank@^0.0.2:
version "0.0.2"
resolved "https://registry.yarnpkg.com/is-string-and-not-blank/-/is-string-and-not-blank-0.0.2.tgz#cd19eded2ca4a514f79ca528915f1fb28e5dd38a"
integrity sha512-FyPGAbNVyZpTeDCTXnzuwbu9/WpNXbCfbHXLpCRpN4GANhS00eEIP5Ef+k5HYSNIzIhdN9zRDoBj6unscECvtQ==
dependencies:
is-string-blank "^1.0.1"

is-string-blank@^1.0.1:
version "1.0.1"
resolved "https://registry.yarnpkg.com/is-string-blank/-/is-string-blank-1.0.1.tgz#866dca066d41d2894ebdfd2d8fe93e586e583a03"
integrity sha512-9H+ZBCVs3L9OYqv8nuUAzpcT9OTgMD1yAWrG7ihlnibdkbtB850heAmYWxHuXc4CHy4lKeK69tN+ny1K7gBIrw==

is-string@^1.1.1:
version "1.1.1"
resolved "https://registry.yarnpkg.com/is-string/-/is-string-1.1.1.tgz#92ea3f3d5c5b6e039ca8677e5ac8d07ea773cbb9"
Expand Down Expand Up @@ -6317,13 +6283,6 @@ is-unicode-supported@^0.1.0:
resolved "https://registry.yarnpkg.com/is-unicode-supported/-/is-unicode-supported-0.1.0.tgz#3f26c76a809593b52bfa2ecb5710ed2779b522a7"
integrity sha512-knxG2q4UC3u8stRGyAVJCOdxFmv5DZiRcdlIaAQXAbSfJya+OhopNotLQrstBhququ4ZpuKbDc/8S6mgXgPFPw==

is-valid-path@^0.1.1:
version "0.1.1"
resolved "https://registry.yarnpkg.com/is-valid-path/-/is-valid-path-0.1.1.tgz#110f9ff74c37f663e1ec7915eb451f2db93ac9df"
integrity sha512-+kwPrVDu9Ms03L90Qaml+79+6DZHqHyRoANI6IsZJ/g8frhnfchDOBCa0RbQ6/kdHt5CS5OeIEyrYznNuVN+8A==
dependencies:
is-invalid-path "^0.1.0"

is-weakmap@^2.0.2:
version "2.0.2"
resolved "https://registry.yarnpkg.com/is-weakmap/-/is-weakmap-2.0.2.tgz#bf72615d649dfe5f699079c54b83e47d1ae19cfd"
Expand Down Expand Up @@ -7429,7 +7388,7 @@ [email protected]:
resolved "https://registry.yarnpkg.com/ms/-/ms-2.1.2.tgz#d09d1f357b443f493382a8eb3ccd183872ae6009"
integrity sha512-sGkPx+VjMtmA6MX27oA4FBFELFCZZ4S4XqeGOXCv68tT+jb3vk/RyaKWP0PTKyWtmLSM0b+adUTEvbs1PEaH2w==

[email protected], ms@^2.0.0, ms@^2.1.2, ms@^2.1.3:
[email protected], ms@^2.0.0, ms@^2.1.3:
version "2.1.3"
resolved "https://registry.yarnpkg.com/ms/-/ms-2.1.3.tgz#574c8138ce1d2b5861f0b44579dbadd60c6615b2"
integrity sha512-6FlzubTLZG3J2a/NVCAleEhjzq5oxgHyaCU9yYXvcLsvoVaHJq/s5xXI6/XXP6tz7R9xAOtHnSO/tXtF3WRTlA==
Expand Down Expand Up @@ -7846,14 +7805,7 @@ p-try@^2.0.0:
resolved "https://registry.yarnpkg.com/p-try/-/p-try-2.2.0.tgz#cb2868540e313d61de58fafbe35ce9004d5540e6"
integrity sha512-R4nPAVTAU0B9D35/Gk3uJf/7XYbQcyohSKdvAxIRSNghFl4e71hVoGnBNQz9cWaXxO2I10KTC+3jMdvvoKw6dQ==

[email protected]:
version "3.1.0"
resolved "https://registry.yarnpkg.com/p-wait-for/-/p-wait-for-3.1.0.tgz#9da568a2adda3ea8175a3c43f46a5317e28c0e47"
integrity sha512-0Uy19uhxbssHelu9ynDMcON6BmMk6pH8551CvxROhiz3Vx+yC4RqxjyIDk2V4ll0g9177RKT++PK4zcV58uJ7A==
dependencies:
p-timeout "^3.0.0"

[email protected]:
p-wait-for@3, [email protected]:
version "3.2.0"
resolved "https://registry.yarnpkg.com/p-wait-for/-/p-wait-for-3.2.0.tgz#640429bcabf3b0dd9f492c31539c5718cb6a3f1f"
integrity sha512-wpgERjNkLrBiFmkMEjuZJEWKKDrNfHCKA1OhyN1wg1FrLkULbviEy6py1AyJUgZ72YWFbZ38FIpnqvVqAlDUwA==
Expand Down