Repository navigation
fix(ui5-list): suppress F2 aria description for custom items without tabbables - #13865
Conversation
…tabbables Previously the "To move to the content, press F2" hint was announced for every ui5-li-custom, on the assumption that custom items may host arbitrary tabbable slot content. In the very common case where ui5-li-custom is used purely for visual richness (icon + description + additional text), the hint was misleading - F2 has nowhere to go, so pressing it does nothing. Replace the type-based check in _hasInteractiveItems with a behavioural call to _hasFocusableElements(), so the announcement matches what F2 actually does. Related to: #13489 Fixes: #13713
|
🚀 Deployed on https://pr-13865--ui5-webcomponents-preview.netlify.app |
|
Quick before/after for reviewers 👀 Same playground fragment (customer's exact repro from #13713), rendered against
How to inspect: open DevTools → find |
|
🧹 Preview deployment cleaned up: https://pr-13865--ui5-webcomponents.netlify.app |
|
🎉 This PR is included in version v2.26.0-rc.0 🎉 The release is available on v2.26.0-rc.0 Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version v2.26.0 🎉 The release is available on v2.26.0 Your semantic-release bot 📦🚀 |
This branch was previously deployed
2 participants
Previously the "To move to the content, press F2" hint was announced for every
ui5-li-custom, on the assumption that custom items may host arbitrary tabbable slot content. In the very common case whereui5-li-customis used purely for visual richness (icon + description + additional text), the hint was misleading - F2 has nowhere to go, so pressing it does nothing.Replace the type-based check in
_hasInteractiveItemswith a behavioural call to_hasFocusableElements(), so the announcement matches what F2 actually does.Related to: #13489
Fixes: #13713