Say how much time a temporal mean averaged over - #123
Merged
Conversation
Both temporal_mean and anomaly reduce along time and both return a full-length array whatever went in. Measured on a 6-element, 12-step file: a variable missing at every step came back outcome complete with a field of NaN, a one-step file came back as an "anomaly" of exactly 0.0 everywhere, and elements holding 1, 2 and 12 usable steps were averaged into one finite summary. Results now carry temporal_coverage with n_time, samples_min/max, n_elements_with_value, n_series_with_data and, under groupby, n_bins with bin_occupancy_min/max. An empty mean refuses; a one-step baseline refuses on anomaly alone, since that array reads the same for any data. A one-step temporal_mean only warns, because the value was measured and only the word "mean" is wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
temporal_meanandanomalyboth reduce alongtimeand both return a full-length array whatever went in, so an all-NaN variable came back asoutcome: completewith a field of NaN and a one-step file came back as an "anomaly" of exactly 0.0 at every element. Results now carry atemporal_coverageblock, an empty mean refuses, a one-step baseline refuses onanomalyalone, and uneven per-element sample counts or single-samplegroupbybins warn. 870 passed, 18 skipped locally with all pre-commit hooks green.