Update fee accrual explanation for Uniswap v4 #1095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarified the behaviour of fee accrual and claims in Uniswap v4, emphasising automatic handling of unclaimed fees during liquidity changes. After testing and exploration of the codebase, the previous message claims that the unclaimed fees are proportionally claimed based on what we remove from the LP position. But based on tests of part of the UNIV4 codebases, the full amount of unclaimed fees for that position is always gathered.
|
@talfao is attempting to deploy a commit to the Uniswap Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clarified the behaviour of fee accrual and claims in Uniswap v4, emphasising automatic handling of unclaimed fees during liquidity changes.
After testing and exploration of the codebase, the previous message claims that the unclaimed fees are proportionally claimed based on what we remove from the LP position. But based on tests of part of the UNIV4 codebases, the full amount of unclaimed fees for that position is always gathered.
Type(s) of changes
Motivation for PR
No misleading in docs!
How Has This Been Tested?
Position.t.soltests confirm this, and then some tests we crafted on our own for the audit we are performing for codebase using UniV4Applicable screenshots
Follow-up PR