Restore process dump synchronization warnings - #6163
Draft
Victor-Su-Ortiz wants to merge 1 commit into
Draft
Victor-Su-Ortiz wants to merge 1 commit into
Victor-Su-Ortiz wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6028. Re-enable the saved/running process-list warning in
pm2 ls. Compare names without depending on order and account for repeated process names, including equal-sized lists with different multiplicities. Ignore PM2 modules.Add seven focused cases in an owned temporary PM2 home and register them in the unit runner.
Verification
test/programmatic/dump.mocha.js: six passed in an isolated short temporary PM2 home.git diff --checkpassed.The model's sandboxed daemon tests timed out; the independent reviewer reran them successfully outside that sandbox with isolated state. The full e2e suite was not run because some scripts hardcode the user's default PM2 home. This repository defines neither an npm lint nor a typecheck script.
AI assistance
Implementation and tests generated with OpenCode
opencode/space-bunny-free(Space Bunny). Codex independently reviewed and ran the checks and requested isolation and duplicate-name test corrections. No human code review has occurred. Submitted as a draft for maintainer review.