Skip to content

Restore process dump synchronization warnings - #6163

Draft
Victor-Su-Ortiz wants to merge 1 commit into
Unitech:developmentfrom
Victor-Su-Ortiz:minimax/dump-sync-warning-6028
Draft

Victor-Su-Ortiz wants to merge 1 commit into
Unitech:developmentfrom
Victor-Su-Ortiz:minimax/dump-sync-warning-6028

Conversation

@Victor-Su-Ortiz

Copy link
Copy Markdown

Summary

Fixes #6028. Re-enable the saved/running process-list warning in pm2 ls. Compare names without depending on order and account for repeated process names, including equal-sized lists with different multiplicities. Ignore PM2 modules.

Add seven focused cases in an owned temporary PM2 home and register them in the unit runner.

Verification

  • The new regression fails on the original production code and passes after the fix: seven cases passed.
  • Existing test/programmatic/dump.mocha.js: six passed in an isolated short temporary PM2 home.
  • Real CLI flow passed: save A → synchronized; start B → warning; save A+B → synchronized; delete A → warning. The test daemon was stopped afterward.
  • Node syntax checks and git diff --check passed.

The model's sandboxed daemon tests timed out; the independent reviewer reran them successfully outside that sandbox with isolated state. The full e2e suite was not run because some scripts hardcode the user's default PM2 home. This repository defines neither an npm lint nor a typecheck script.

AI assistance

Implementation and tests generated with OpenCode opencode/space-bunny-free (Space Bunny). Codex independently reviewed and ran the checks and requested isolation and duplicate-name test corrections. No human code review has occurred. Submitted as a draft for maintainer review.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants