Skip to content

Comments

CHANGE: Removing old mentions of UNITY_2021#2351

Open
josepmariapujol-unity wants to merge 4 commits intodevelopfrom
input/2021-mentions-removal
Open

CHANGE: Removing old mentions of UNITY_2021#2351
josepmariapujol-unity wants to merge 4 commits intodevelopfrom
input/2021-mentions-removal

Conversation

@josepmariapujol-unity
Copy link
Collaborator

@josepmariapujol-unity josepmariapujol-unity commented Feb 20, 2026

Description

CHANGE: Removing old mentions of UNITY_2021

Testing status & QA

N/A

Overall Product Risks

Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.

  • Complexity: 0
  • Halo Effect: 0

Comments to reviewers

Please describe any additional information such as what to focus on, or historical info for the reviewers.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@josepmariapujol-unity josepmariapujol-unity self-assigned this Feb 20, 2026
@josepmariapujol-unity josepmariapujol-unity marked this pull request as ready for review February 20, 2026 15:23
@u-pr
Copy link
Contributor

u-pr bot commented Feb 20, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

 Estimated effort to review: 1 🔵⚪⚪⚪⚪

The PR consists of simple removals of legacy `#if UNITY_2021_...` conditional compilation directives, which is straightforward to verify.
🏅 Score: 100

The code cleanly removes legacy conditional compilations and leaves the modern test logic intact with no formatting issues or syntax errors.
🧪 PR contains tests
🔒 No security concerns identified
⚡ No major issues detected
  • Update review

🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr

@josepmariapujol-unity josepmariapujol-unity changed the title Input/2021 mentions removal CHANGE: Removing old mentions of EDITOR_2021 Feb 20, 2026
@u-pr
Copy link
Contributor

u-pr bot commented Feb 20, 2026

PR Code Suggestions ✨

No code suggestions found for the PR.

@codecov-github-com
Copy link

codecov-github-com bot commented Feb 20, 2026

Codecov Report

All modified and coverable lines are covered by tests ✅

@@             Coverage Diff             @@
##           develop    #2351      +/-   ##
===========================================
- Coverage    77.95%   77.89%   -0.07%     
===========================================
  Files          476      476              
  Lines        97453    97613     +160     
===========================================
+ Hits         75971    76036      +65     
- Misses       21482    21577      +95     
Flag Coverage Δ
inputsystem_MacOS_2022.3 5.53% <ø> (-0.02%) ⬇️
inputsystem_MacOS_2022.3_project 75.39% <100.00%> (-0.08%) ⬇️
inputsystem_MacOS_6000.0 5.30% <ø> (-0.02%) ⬇️
inputsystem_MacOS_6000.0_project 77.29% <100.00%> (-0.07%) ⬇️
inputsystem_MacOS_6000.3 5.31% <ø> (-0.02%) ⬇️
inputsystem_MacOS_6000.3_project 77.29% <100.00%> (-0.07%) ⬇️
inputsystem_MacOS_6000.4 5.31% <ø> (-0.02%) ⬇️
inputsystem_MacOS_6000.4_project 77.30% <100.00%> (-0.07%) ⬇️
inputsystem_MacOS_6000.5 5.31% <ø> (-0.02%) ⬇️
inputsystem_MacOS_6000.5_project 77.30% <100.00%> (-0.07%) ⬇️
inputsystem_Ubuntu_2022.3 5.53% <ø> (-0.02%) ⬇️
inputsystem_Ubuntu_2022.3_project 75.19% <100.00%> (-0.08%) ⬇️
inputsystem_Ubuntu_6000.0 5.31% <ø> (-0.02%) ⬇️
inputsystem_Ubuntu_6000.0_project 77.09% <100.00%> (-0.07%) ⬇️
inputsystem_Ubuntu_6000.3 5.31% <ø> (-0.02%) ⬇️
inputsystem_Ubuntu_6000.3_project 77.09% <100.00%> (-0.08%) ⬇️
inputsystem_Ubuntu_6000.4 5.32% <ø> (-0.02%) ⬇️
inputsystem_Ubuntu_6000.4_project 77.10% <100.00%> (-0.07%) ⬇️
inputsystem_Ubuntu_6000.5 5.32% <ø> (-0.02%) ⬇️
inputsystem_Ubuntu_6000.5_project 77.10% <100.00%> (-0.07%) ⬇️
inputsystem_Windows_2022.3 5.53% <ø> (-0.02%) ⬇️
inputsystem_Windows_2022.3_project 75.52% <100.00%> (-0.08%) ⬇️
inputsystem_Windows_6000.0 5.30% <ø> (-0.02%) ⬇️
inputsystem_Windows_6000.0_project 77.42% <100.00%> (-0.08%) ⬇️
inputsystem_Windows_6000.3 5.31% <ø> (-0.02%) ⬇️
inputsystem_Windows_6000.3_project 77.42% <100.00%> (-0.08%) ⬇️
inputsystem_Windows_6000.4 5.31% <ø> (-0.02%) ⬇️
inputsystem_Windows_6000.4_project 77.43% <100.00%> (-0.07%) ⬇️
inputsystem_Windows_6000.5 5.31% <ø> (-0.02%) ⬇️
inputsystem_Windows_6000.5_project 77.42% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../Tests/InputSystem/Plugins/DeviceSimulatorTests.cs 100.00% <ø> (ø)
Assets/Tests/InputSystem/Plugins/UITests.cs 94.67% <100.00%> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@josepmariapujol-unity josepmariapujol-unity changed the title CHANGE: Removing old mentions of EDITOR_2021 CHANGE: Removing old mentions of UNITY_2021 Feb 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant