chore: simplify accessors network object #3831
Open
+63
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noellie-velez
commented
Dec 29, 2025
|
|
||
| // Standard non-authority synchronization is handled here | ||
| if (!CanCommitToTransform && NetworkManager.IsConnectedClient && SynchronizeState.IsSynchronizing) | ||
| if (!CanCommitToTransform && m_CachedNetworkManager.IsConnectedClient && SynchronizeState.IsSynchronizing) |
Collaborator
Author
There was a problem hiding this comment.
Is this change useful on an optimization point of view?
| var forUpdate = true; | ||
| #endif | ||
| if (m_CachedNetworkObject != null) | ||
| if (m_CachedNetworkObject) |
Collaborator
Author
There was a problem hiding this comment.
Rider suggested converting "==" to explicit Unity engine object lifetime check. Should we keep or revert those changes?
| return GlobalObjectIdHash; | ||
| } | ||
| } | ||
| public uint PrefabIdHash => GlobalObjectIdHash; |
Collaborator
Author
There was a problem hiding this comment.
Should we keep this in multiple lines instead of my change?
| // the NetworkManager is shutting down, the NetworkObject is not spawned, it is an in-scene placed | ||
| // NetworkObject, or the GameObject's current scene handle is the same as the SceneOriginHandle | ||
| if (!SceneMigrationSynchronization || !IsSpawned || NetworkManager == null || NetworkManager.ShutdownInProgress || | ||
| if (!SceneMigrationSynchronization || !IsSpawned || NetworkManager.ShutdownInProgress || |
Collaborator
Author
There was a problem hiding this comment.
Should we keep NetworkManager null checks here?
| // Early exit if there is no NetworkManager assigned, the NetworkManager is shutting down, the NetworkObject | ||
| // is not spawned, or an in-scene placed NetworkObject | ||
| if (NetworkManager == null || NetworkManager.ShutdownInProgress || !IsSpawned || IsSceneObject != false) | ||
| if (NetworkManager.ShutdownInProgress || !IsSpawned || IsSceneObject != false) |
Collaborator
Author
There was a problem hiding this comment.
Should we keep the NetworkManager null checks here?
| /// Gets if the object is the personal clients player object | ||
| /// </summary> | ||
| public bool IsLocalPlayer => NetworkManager != null && IsPlayerObject && OwnerClientId == NetworkManager.LocalClientId; | ||
| public bool IsLocalPlayer => IsPlayerObject && OwnerClientId == NetworkManager.LocalClientId; |
Collaborator
Author
There was a problem hiding this comment.
If I understand correctly, NetworkManager cannot be null as we are using the Singleton so I removed some NetworkManager null checks. Should those checks be kept anyways?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Jira ticket
MTT-13657
Changelog
Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports