Skip to content

[bug-fix] Fix sequence length buffer truncate#5456

Closed
ervteng wants to merge 3 commits into
mainfrom
develop-fix-sac-truncate-seq
Closed

[bug-fix] Fix sequence length buffer truncate#5456
ervteng wants to merge 3 commits into
mainfrom
develop-fix-sac-truncate-seq

Conversation

@ervteng

@ervteng ervteng commented Jul 15, 2021

Copy link
Copy Markdown
Contributor

Proposed change(s)

Fixed an issue where if 80% of the buffer isn't a multiple of sequence length, we'll get weird sequences in the buffer. Only affects SAC with LSTM.

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@ervteng ervteng requested a review from andrewcoh July 15, 2021 00:55
@miguelalonsojr miguelalonsojr self-assigned this Jan 18, 2022
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Ervin Teng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@montplaisir

Copy link
Copy Markdown

Thank you for your submission!
Your changes were ported to PR #6301.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants