Skip to content

Fix bug with stacking sensor(#5790)#5806

Closed
x-mug wants to merge 1 commit into
Unity-Technologies:mainfrom
x-mug:main
Closed

Fix bug with stacking sensor(#5790)#5806
x-mug wants to merge 1 commit into
Unity-Technologies:mainfrom
x-mug:main

Conversation

@x-mug

@x-mug x-mug commented Oct 19, 2022

Copy link
Copy Markdown
Contributor

grid sensor and all PNG compression used will face this bug when channel number is larger than 3 && used stacking observation (stack > 1)

Proposed change(s)

Describe the changes made in this PR.

The prepared empty PNG will be multiplied based on the channel number used

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

#5790

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

grid sensor and all PNG compression used will face this bug when channel number is larger than 3 && used stacking observation (stack > 1)
@CLAassistant

CLAassistant commented Oct 19, 2022

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@montplaisir

Copy link
Copy Markdown
Contributor

Thank you for your submission!
I updated your changes and added a test. See PR #6299.

montplaisir added a commit that referenced this pull request Jun 16, 2026
* Fix bug with stacking sensor(#5790)

grid sensor and all PNG compression used will face this bug when channel number is larger than 3 && used stacking observation (stack > 1)

* Fix Stacking Sensor when more than 3 channels
Update PR #5806 that fixes issue #5790 - GridSensor Observation Stacks Greater Than 1 Throws Exception.
The prepared empty PNG is now multiplied based on the channel number used.

---------

Co-authored-by: xmug <hzjgames@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants