Remove assertions from ToFileDescriptor - #2226
Open
kg-unity3d wants to merge 1 commit into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
fd < sysconf(_SC_OPEN_MAX)assertion is wrong (_SC_OPEN_MAXcan be changed at runtime, stranding valid fds above the limit) and the0 <= fdis correct but not especially useful - we would pass the negative fd through to the kernel and get back a meaningful errno anyway, which would generate a managed exception that can be handled instead of asserting and unconditionally tearing down the process.Reviewers: please consider these questions as well! ❤️
Release notes
Changed UUM-145761 @kg-unity3d:
Mono: Remove assertions from ToFileDescriptor