feat: add sdk flavor metadata#395
Merged
Merged
Conversation
also to re-export the constants from provider
irstavr
force-pushed
the
feat/sdk-flavor-metadata
branch
2 times, most recently
from
July 17, 2026 08:29
3bd7489 to
97e90df
Compare
for more information, see https://pre-commit.ci
sighphyre
approved these changes
Jul 17, 2026
sighphyre
left a comment
sighphyre
left a comment
Member
There was a problem hiding this comment.
Seems sane to me. Left a suggestion around cleaning up the way we pass around the flavour fields but it's not a biggie, up to you
the params are now Optional[str] instead of the helper's Any
irstavr
marked this pull request as ready for review
July 20, 2026 17:47
Coverage Report for CI Build 29819406661Coverage increased (+0.1%) to 93.194%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
irstavr
enabled auto-merge (squash)
July 20, 2026 22:31
irstavr
disabled auto-merge
July 21, 2026 00:18
irstavr
force-pushed
the
feat/sdk-flavor-metadata
branch
from
July 21, 2026 08:46
ded8067 to
0864713
Compare
sighphyre
approved these changes
Jul 21, 2026
irstavr
enabled auto-merge (squash)
July 21, 2026 09:42
sighphyre
disabled auto-merge
July 21, 2026 10:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds skd flavor metadata when building up and sets them properly when register and send metrics.
Get it ready for use in the provider side