CheckWorkerHealth in Parallel.Wait() to prevent deadlock#15
Open
ToniKoehler wants to merge 2 commits intoVFPX:masterfrom
Open
CheckWorkerHealth in Parallel.Wait() to prevent deadlock#15ToniKoehler wants to merge 2 commits intoVFPX:masterfrom
ToniKoehler wants to merge 2 commits intoVFPX:masterfrom
Conversation
parallelfox.vca from original VFPX repository is not proper version to parallelfox.vcx/.vct, so first create correct .vca with SourceSafe
If, for some reason, one or more workers crash and either parallelfox.exe or a thread stops working, the Parallel.Wait() call in the main process will continue waiting for that "busy" worker without realizing that it has crashed. This results in a deadlock. To prevent this, we now check both the Out-of-Process and In-Process workers to ensure they are still alive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If, for some reason, one or more workers crash and either parallelfox.exe or a thread stops working, the Parallel.Wait() call in the main process will continue waiting for that "busy" worker without realizing that it has crashed. This results in a deadlock. To prevent this, we now check both the Out-of-Process and In-Process workers to ensure they are still alive.