Skip to content

Fix slice handling in FunctionList, BasicBlockList, and TagList #7911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3rdit wants to merge 2 commits into
base: dev
Choose a base branch
from
+6 −12
Open

Fix slice handling in FunctionList, BasicBlockList, and TagList #7911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b8d948
Fix TypeError when slicing FunctionList/BasicBlockList with [:], [n:]…
3rdit Jan 22, 2026
131675d
Fix slice handling in TagList to match FunctionList/BasicBlockList fix
3rdit Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions python/binaryview.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2466,10 +2466,8 @@ def __getitem__(self, i: Union[int, slice]) -> Union['_function.Function', List[
return _function.Function(self._view, core.BNNewFunctionReference(self._funcs[i]))
elif isinstance(i, slice):
result = []
if i.start < 0 or i.start >= len(self) or i.stop < 0 or i.stop >= len(self):
raise IndexError(f"Slice {i} out of bounds for FunctionList of size {len(self)}")

for j in range(i.start, i.stop, i.step if i.step is not None else 1):
start, stop, step = i.indices(len(self))
for j in range(start, stop, step):
result.append(_function.Function(self._view, core.BNNewFunctionReference(self._funcs[j])))
return result
raise ValueError("FunctionList.__getitem__ supports argument of type integer or slice")
Expand Down
12 changes: 4 additions & 8 deletions python/function.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,10 +279,8 @@ def __getitem__(self, i: Union[int, slice]) -> Union['basicblock.BasicBlock', Li
return self._function._instantiate_block(block)
elif isinstance(i, slice):
result = []
if i.start < 0 or i.start >= len(self) or i.stop < 0 or i.stop >= len(self):
raise IndexError(f"Slice {i} out of bounds for BasicBlockList of size {len(self)}")

for j in range(i.start, i.stop, i.step if i.step is not None else 1):
start, stop, step = i.indices(len(self))
for j in range(start, stop, step):
block = core.BNNewBasicBlockReference(self._blocks[j])
assert block is not None, "core.BNNewBasicBlockReference returned None"
result.append(self._function._instantiate_block(block))
Expand Down Expand Up @@ -400,10 +398,8 @@ def __getitem__(
return arch, self._tags[i].addr, binaryview.Tag(core_tag)
elif isinstance(i, slice):
result = []
if i.start < 0 or i.start >= len(self) or i.stop < 0 or i.stop >= len(self):
raise IndexError(f"Slice {i} out of bounds for TagList of size {len(self)}")

for j in range(i.start, i.stop, i.step if i.step is not None else 1):
start, stop, step = i.indices(len(self))
for j in range(start, stop, step):
core_tag = core.BNNewTagReference(self._tags[j].tag)
assert core_tag is not None, "core.BNNewTagReference returned None"
arch = architecture.CoreArchitecture._from_cache(self._tags[j].arch)
Expand Down