refactor: migrate rust crates to edition 2024#8338
Closed
seuros wants to merge 1 commit into
Closed
Conversation
Run cargo fix --edition on binaryninja and binaryninjacore-sys, bump both manifests to edition 2024, and resolve what the tool could not: - wrap unsafe operations in explicit unsafe blocks (unsafe_op_in_unsafe_fn) - drop explicit ref binding modifiers in implicitly-borrowing match patterns (RFC 3627) - extend temporary lifetimes with let bindings in type archive callbacks and Relocation::info (edition 2024 temporary drop order) - remove redundant nested unsafe blocks left by the mechanical rewrite
|
|
Member
|
Make an issue please with specific instances of UB, or why you need 2024, otherwise we will bump to 2024 ourselves when we get the chance. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run cargo fix --edition on binaryninja and binaryninjacore-sys, bump both manifests to edition 2024
Most of the change were automated by the fix. There is more cosmetic changes possible (like order of the imports), but i reverted those.