feat: move arrpc server into a worker thread

[pendo324]

Solution for #1009, which I can reliably reproduce without this change.

I have another version of this which instead works with this arrpc PR OpenAsar/arrpc#133, but it seems like Vesktop might be the appropriate place to put this complexity.

I have tested that game status RPC works as expected but I haven't found a game with which to test invites.

[Covkie]

invite events are simply opening https://discord.gg/D9uwnFnqmd in your browser of choice and it sending that to your open client. The callback is so the website can display its completed or error thing

Same case as #1016

[Covkie]

anyway yeah doesn't work for invites

[pendo324]

invite events are simply opening https://discord.gg/D9uwnFnqmd in your browser of choice and it sending that to your open client. The callback is so the website can display its completed or error thing

Same case as #1016

Oh, I thought it was game invites, lol. Thanks for the info. Let me see what's up. It should be fixable, I think

[pendo324]

Off by one error, works on my side now

[Covkie]

Instead of writing an insane review with github web editor heres a patch. It's functionally the same but doesn't have the hardcoded types (?) or add a new dep

buh.patch

[pendo324]

Instead of writing an insane review with github web editor heres a patch. It's functionally the same but doesn't have the hardcoded types (?) or add a new dep

buh.patch

Thanks. I removed the new dependency in my latest revision. Not sure why we wouldn't want the types?

[Covkie]

You're over complicating it by quite a bit, sending the data over postMessage is fine, you don't need to handle the port stuff yourself & worker.on error exists so you dont need a try catch.
patch.txt

Also please stop forcing pushing it makes it insane to follow changes 😭

[pendo324]

You're over complicating it by quite a bit

Agree to disagree, I suppose. It's much more readable to me with the MessageChannel, and adds like... 1 line of code, which is why I didn't use postMessage. I’m surprised your code works using a .ts file for the worker, even when it isn’t explicitly loaded using an import/require (you reference the js output, which I’m surprised is included by ESBuild in the bundle when it’s not ever imported). Let me try removing the new entrypoint I added and see if that works.

You also use a map instead of an array for storing the invites, which is fine too, but I don’t really see why you’d need an id more unique than a monotonically increasing array index for that. Maybe it’s more extendable.

Also please stop forcing pushing it makes it insane to follow changes 😭

Sure. Habit from other projects I contribute to where this is the expected workflow. I just use the "see changes since last revision" button.

[Vendicated]

Thank you for your PR!

I took the freedom to refactor it to be more idiomatic and use more appropriate data structures (Map with uuids over an Array with indexes)

Besides that it looks good

[Vendicated]

just realised you forgot to handle the link event inside the worker

[Vendicated]

4baf6de