Compare snapshots with whitespace significant - #773
Merged
Conversation
DiffPlex's ignoreWhiteSpace parameter defaults to true, so DiffRows was asking for a diff that treats indentation and trailing space as nothing. A snapshot failing only on whitespace came back Unchanged on every row: the panes drew no markers, NextChange found nothing to move to, and the reviewer was shown a failing test with no visible difference and no way to see what it was. That is not an edge case here. The F# layout convention is entirely about leading whitespace, and trailing space is a common snapshot failure. Pass ignoreWhiteSpace: false and ignoreCase: false explicitly, so both are stated rather than inherited. No existing snapshot changed, which is the other half of the result: whitespace sensitivity only adds differences that were being hidden.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DiffPlex's ignoreWhiteSpace parameter defaults to true, so DiffRows was asking for a diff that treats indentation and trailing space as nothing. A snapshot failing only on whitespace came back Unchanged on every row: the panes drew no markers, NextChange found nothing to move to, and the reviewer was shown a failing test with no visible difference and no way to see what it was.
That is not an edge case here. The F# layout convention is entirely about leading whitespace, and trailing space is a common snapshot failure.
Pass ignoreWhiteSpace: false and ignoreCase: false explicitly, so both are stated rather than inherited. No existing snapshot changed, which is the other half of the result: whitespace sensitivity only adds differences that were being hidden.