Clear the tracked process after killing it - #776
Merged
Conversation
KillProcesses disposes the diff tool's Process and left the reference on the
TrackedMove. That is fine when the accept succeeds, because the entry goes; the
problem is that it often does not. InnerMove kills first and then tries the
move, and a locked target, the user choosing Ignore, or the eight retries
running out all re-add the very same object to the dictionary.
The entry is then pending with a disposed Process on it, and two paths read that
property: the Accept-open hot key, which filters on Process is { HasExited:
false }, and "Open diff tool" via DiffToolLauncher. Both throw
InvalidOperationException, "No process is associated with this object", on the
UI thread — where nothing is hooked to Application.ThreadException, so the tray
takes the exception dialog.
Null the property after disposing, which is what DiffToolLauncher already does
in the same situation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KillProcesses disposes the diff tool's Process and left the reference on the TrackedMove. That is fine when the accept succeeds, because the entry goes; the problem is that it often does not. InnerMove kills first and then tries the move, and a locked target, the user choosing Ignore, or the eight retries running out all re-add the very same object to the dictionary.
The entry is then pending with a disposed Process on it, and two paths read that property: the Accept-open hot key, which filters on Process is { HasExited: false }, and "Open diff tool" via DiffToolLauncher. Both throw InvalidOperationException, "No process is associated with this object", on the UI thread — where nothing is hooked to Application.ThreadException, so the tray takes the exception dialog.
Null the property after disposing, which is what DiffToolLauncher already does in the same situation.