Exercise the sync launch from the sync named tests - #781
Merged
Conversation
LaunchAndKill and LaunchAndKillAsync were byte identical, and both awaited LaunchAsync. So were LaunchAndKillDisabled and its Async twin, and the two MaxInstancesToLaunch cases. The synchronous DiffRunner.Launch had no coverage at all while the suite carried four tests whose names said it did. Point the non-Async half at DiffRunner.Launch. Worth having on its own terms: the two overloads do not resolve the tool the same way — Launch asks TryFindByExtension and LaunchAsync asks TryFindForInputFilePath — so a pair of tests that only ever calls one of them cannot see the two drift apart.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LaunchAndKill and LaunchAndKillAsync were byte identical, and both awaited LaunchAsync. So were LaunchAndKillDisabled and its Async twin, and the two MaxInstancesToLaunch cases. The synchronous DiffRunner.Launch had no coverage at all while the suite carried four tests whose names said it did.
Point the non-Async half at DiffRunner.Launch. Worth having on its own terms: the two overloads do not resolve the tool the same way — Launch asks TryFindByExtension and LaunchAsync asks TryFindForInputFilePath — so a pair of tests that only ever calls one of them cannot see the two drift apart.