Remove unused stuff & Cleanup/Reformatting #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/net/raphimc/vialegacy/api/model/Location.java # src/main/java/net/raphimc/vialegacy/protocol/release/r1_1tor1_2_1_3/biome/beta/NoiseGeneratorOctaves2.java # src/main/java/net/raphimc/vialegacy/protocol/release/r1_1tor1_2_1_3/biome/beta/WorldChunkManager_b1_7.java # src/main/java/net/raphimc/vialegacy/protocol/release/r1_1tor1_2_1_3/biome/release/BiomeCache.java
RaphiMC
requested changes
Jan 19, 2026
Member
RaphiMC
left a comment
RaphiMC
left a comment
There was a problem hiding this comment.
Most of the newline changes are unnecessary. Don't use String.format for toString methods. The pre netty types read code is also inconsistent (Sometimes you did < -1 and sometimes <= 0). Maybe PR smaller changes/areas instead of reformating/refactoring a bunch of code all over the place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.