Skip to content

Freeze ViewComponent::VERSION::STRING (audition round 2) #2672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joelhawksley merged 1 commit into from
Jul 24, 2026
+5 −2
Merged

Freeze ViewComponent::VERSION::STRING (audition round 2) #2672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .audition-baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,6 @@
"runtime-unshareable-constant|/Users/joelhawksley/.local/share/mise/installs/ruby/4.0.5/lib/ruby/gems/4.0.0/gems/i18n-1.14.8/lib/i18n/interpolate/ruby.rb": 1,
"runtime-unshareable-constant|/Users/joelhawksley/.local/share/mise/installs/ruby/4.0.5/lib/ruby/gems/4.0.0/gems/logger-1.7.0/lib/logger.rb": 1,
"runtime-unshareable-constant|/Users/joelhawksley/github/view_component/lib/view_component/deprecation.rb": 1,
"runtime-unshareable-constant|/Users/joelhawksley/github/view_component/lib/view_component/version.rb": 1,
"unsafe-calls|lib/view_component/base.rb": 1,
"unsafe-calls|lib/view_component/compile_cache.rb": 1,
"unsafe-calls|lib/view_component/compiler.rb": 3,
Expand Down
4 changes: 4 additions & 0 deletions docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ nav_order: 6

## main

* Freeze `ViewComponent::VERSION::STRING` so the version constant is immutable and Ractor-shareable.

*Joel Hawksley*

* Add [audition](https://github.com/yaroslav/audition) Ractor-readiness checks to CI. Applied safe `.freeze` auto-fixes to string constants in `ViewComponent::Errors` and baselined existing findings so the gate fails only on new Ractor-isolation violations.

*Joel Hawksley*
Expand Down
2 changes: 1 addition & 1 deletion lib/view_component/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ module VERSION
PATCH = 0
PRE = nil

STRING = [MAJOR, MINOR, PATCH, PRE].compact.join(".")
STRING = [MAJOR, MINOR, PATCH, PRE].compact.join(".").freeze
end
end

Expand Down
Loading