Skip to content

Swap memarg bit for HasBackingArrayMask and HasMemoryOrderMask#8905

Merged
stevenfontanella merged 1 commit into
mainfrom
memarg-bit
Jul 15, 2026
Merged

Swap memarg bit for HasBackingArrayMask and HasMemoryOrderMask#8905
stevenfontanella merged 1 commit into
mainfrom
memarg-bit

Conversation

@stevenfontanella

Copy link
Copy Markdown
Member

@stevenfontanella stevenfontanella marked this pull request as ready for review July 14, 2026 18:45
@stevenfontanella stevenfontanella requested a review from a team as a code owner July 14, 2026 18:45
@stevenfontanella stevenfontanella requested review from tlively and removed request for a team July 14, 2026 18:45
@stevenfontanella

Copy link
Copy Markdown
Member Author

cc @brendandahl @rmahdav

@stevenfontanella stevenfontanella merged commit 7f87fef into main Jul 15, 2026
16 checks passed
@stevenfontanella stevenfontanella deleted the memarg-bit branch July 15, 2026 17:06
@kripken

kripken commented Jul 15, 2026

Copy link
Copy Markdown
Member

The fuzzer now errors on this bit change. Is that expected?

CompileError: WebAssembly.Module(): Compiling function #21 failed: invalid alignment; expected maximum alignment is 2, actual alignment is 18 @+2485

@kripken

kripken commented Jul 15, 2026

Copy link
Copy Markdown
Member

Should we disable fuzzing of that feature?

stevenfontanella added a commit that referenced this pull request Jul 15, 2026
#8905 made a breaking change to the binary format for relaxed atomics +
multibyte array access which hasn't been done in V8 yet.

This is mostly a revert of #8664, except that relaxed atomics is left
enabled in FUZZER_ARGS
([link](https://github.com/WebAssembly/binaryen/blob/578db5d8ada17bcb2f5ecee60f9049a2b68516fa/scripts/clusterfuzz/run.py#L83)),
since other fuzzing targets (e.g. Binaryen) still support the changed
binary representation.

Part of #8904.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change ordering immediate memarg bit for relaxed atomics

3 participants