Clarify type import/export rules in new factored-out subsection#673
Open
lukewagner wants to merge 1 commit into
Open
Clarify type import/export rules in new factored-out subsection#673lukewagner wants to merge 1 commit into
lukewagner wants to merge 1 commit into
Conversation
alexcrichton
approved these changes
Jul 1, 2026
alexcrichton
left a comment
alexcrichton
left a comment
Collaborator
There was a problem hiding this comment.
Text/test look good to me, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
Explainer.mdmentions the validation rule that imported/exported function types may only transitively refer toresourcetypes that have themselves been imported/exported (thereby giving them an externally-visible name), but there is no mention of the symmetric requirement on the compound value typesrecord,variant,enumandflags(which also need externally-visible names for the sake of bindings generators). This PR intends to plug this spec hole (which has been pointed out a few times recently) to match the existing implementation, as tested by the new WAST test in the PR. But @alexcrichton please LMK if anything doesn't match and then happy to iterate.