Skip to content

Push textContent also for CDATA_SECTION_NODE nodes #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WebReflection merged 2 commits into from
Jan 22, 2025
Merged

Push textContent also for CDATA_SECTION_NODE nodes #296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d5582d
test: assert CDATA sections are included when calling textContent
lppedd Jan 16, 2025
36001ec
fix: push textContent also for CDATA_SECTION_NODE nodes
lppedd Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cjs/interface/element.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,8 @@ class Element extends ParentNode {
const text = [];
let {[NEXT]: next, [END]: end} = this;
while (next !== end) {
if (next.nodeType === TEXT_NODE)
const nodeType = next.nodeType;
if (nodeType === TEXT_NODE || nodeType === CDATA_SECTION_NODE)
text.push(next.textContent);
next = next[NEXT];
}
Expand Down
3 changes: 2 additions & 1 deletion esm/interface/element.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,8 @@ export class Element extends ParentNode {
const text = [];
let {[NEXT]: next, [END]: end} = this;
while (next !== end) {
if (next.nodeType === TEXT_NODE)
const nodeType = next.nodeType;
if (nodeType === TEXT_NODE || nodeType === CDATA_SECTION_NODE)
text.push(next.textContent);
next = next[NEXT];
}
Expand Down
5 changes: 3 additions & 2 deletions test/interface/cdata-section.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,10 @@ let document = (new DOMParser).parseFromString('<html><body><![CDATA[test]]>text
const [cdata, text] = document.documentElement.lastChild.childNodes;

assert(JSON.stringify(cdata.cloneNode()), '[4,"test"]');

assert(JSON.stringify(text.cloneNode()), '[3,"text"]');

assert(document.documentElement.textContent, 'testtext');

assert(text.data, 'text');
assert(text.nodeValue, 'text');
assert(text.textContent, 'text');
Expand All @@ -34,4 +35,4 @@ document = (new DOMParser).parseFromString('<?xml version="1.0" encoding="utf-8"
assert(document.toString(), '<?xml version="1.0" encoding="utf-8"?><html><body><![CDATA[cdata with a <div> tag]]></body></html>');

document = (new DOMParser).parseFromString('<?xml version="1.0" encoding="utf-8"?><html><body><script>/*<![CDATA[*/test/*]]>*/</script></body></html>', 'text/xml');
assert(document.toString(), '<?xml version="1.0" encoding="utf-8"?><html><body><script>/*<![CDATA[*/test/*]]>*/</script></body></html>');
assert(document.toString(), '<?xml version="1.0" encoding="utf-8"?><html><body><script>/*<![CDATA[*/test/*]]>*/</script></body></html>');
3 changes: 2 additions & 1 deletion worker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7764,7 +7764,8 @@ let Element$1 = class Element extends ParentNode {
const text = [];
let {[NEXT]: next, [END]: end} = this;
while (next !== end) {
if (next.nodeType === TEXT_NODE)
const nodeType = next.nodeType;
if (nodeType === TEXT_NODE || nodeType === CDATA_SECTION_NODE)
text.push(next.textContent);
next = next[NEXT];
}
Expand Down
Loading