Fix/components proton - #696
Merged
Merged
Conversation
Two contents.json entries share the key type|verName|verCode for Proton-11.0-1-arm64ec-steam-unix. The second one collided with the first in syncContents() and fell into mergeRemoteMetadata(), which forced isInstalled = true. That flag was only ever correct when the existing entry came from the on-disk scan, so a collision between two remote entries invented a component that was never installed. The phantom listed under Installed with a delete button, but its install directory had never existed, so removal was a no-op and the next sync recreated it. Nothing the user could do would clear the card. Removal also left remote_profile_alias_* preferences behind, so the alias branch stopped matching after an uninstall and execution fell through to the colliding key. isRemoteUrlInstalled() trusted those stale preferences outright, which made the setup wizard skip components that had already been removed. Propagate installed state only when it is true on disk, drop alias preferences when their content is removed, and verify an alias against its install directory before trusting it, pruning it when stale.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.