Add declare( strict_types = 1 ) to all PHP files by meravi · Pull Request #2424 · WordPress/performance

meravi · 2026-03-20T20:09:32Z

Adds declare( strict_types = 1 ); to all PHP source files across the monorepo.
Fixes #2348

github-actions · 2026-03-20T20:09:44Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: meravi <ravikhadka@git.wordpress.org>
Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

meravi · 2026-03-24T08:53:23Z

@westonruter would appreciate a quick look when you have a moment 🙏

mukeshpanchal27 · 2026-03-24T09:09:25Z

@@ -1,4 +1,5 @@
 <?php
+declare( strict_types = 1 );


Should be after the plugin info.

Good catch, thanks! Moved it after the plugin header.

westonruter · 2026-03-24T21:53:15Z

 * @package performance
 */

+ declare( strict_types = 1 );


Suggested change

declare( strict_types = 1 );

declare( strict_types = 1 );

westonruter

Thanks for the PR.

In addition to the trivial PHPCS issue which I left a suggestion for, there are unit test failures related to the new strict types. This will need to be fixed.

westonruter · 2026-03-25T05:03:57Z

@meravi why remove the strict types? The underlying type problem should be fixed so the strict types can exist in all the files.

codecov · 2026-03-25T05:11:07Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.33%. Comparing base (404dcd1) to head (849447a).
⚠️ Report is 19 commits behind head on trunk.

Additional details and impacted files

@@           Coverage Diff           @@
##            trunk    #2424   +/-   ##
=======================================
  Coverage   69.33%   69.33%           
=======================================
  Files          90       90           
  Lines        7749     7749           
=======================================
  Hits         5373     5373           
  Misses       2376     2376

Flag	Coverage Δ
multisite	`69.33% <100.00%> (ø)`
single	`35.73% <100.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This reverts commit 773ce2d.

This reverts commit ec38bb6.

meravi · 2026-03-25T06:20:01Z

I reverted it temporarily for testing, but it’s added back now.
@westonruter

westonruter · 2026-03-25T22:54:14Z

@meravi ok, you can see that the unit tests are still failing. Once they are passing this will be ready for review.

meravi · 2026-03-26T02:37:00Z

@meravi ok, you can see that the unit tests are still failing. Once they are passing this will be ready for review.

I’ve fixed the issues, and the unit tests are now passing 🟢
Ready for review when you have a moment :)

…options/helper.php Co-authored-by: Weston Ruter <westonruter@gmail.com>

Copilot

Pull request overview

Enables PHP strict typing across the Performance Lab monorepo by adding declare( strict_types = 1 ); at the top of PHP source files, aligning the codebase with the stricter type-safety expectations already implied by PHPStan level 8 (Issue #2348).

Changes:

Added declare( strict_types = 1 ); to PHP plugin entrypoints, helpers, and includes across multiple plugins.
Updated the autoloaded-options Site Health helper to ensure option values are stringified before calling strlen() (to avoid type errors with non-string cached values).

Reviewed changes

Copilot reviewed 102 out of 102 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
plugins/webp-uploads/uninstall.php	Add `strict_types` declaration.
plugins/webp-uploads/settings.php	Add `strict_types` declaration.
plugins/webp-uploads/rest-api.php	Add `strict_types` declaration.
plugins/webp-uploads/picture-element.php	Add `strict_types` declaration.
plugins/webp-uploads/load.php	Add `strict_types` declaration.
plugins/webp-uploads/image-edit.php	Add `strict_types` declaration.
plugins/webp-uploads/hooks.php	Add `strict_types` declaration.
plugins/webp-uploads/helper.php	Add `strict_types` declaration.
plugins/webp-uploads/deprecated.php	Add `strict_types` declaration.
plugins/web-worker-offloading/third-party/woocommerce.php	Add `strict_types` declaration.
plugins/web-worker-offloading/third-party/seo-by-rank-math.php	Add `strict_types` declaration.
plugins/web-worker-offloading/third-party/google-site-kit.php	Add `strict_types` declaration.
plugins/web-worker-offloading/third-party.php	Add `strict_types` declaration.
plugins/web-worker-offloading/load.php	Add `strict_types` declaration.
plugins/web-worker-offloading/hooks.php	Add `strict_types` declaration.
plugins/web-worker-offloading/helper.php	Add `strict_types` declaration.
plugins/view-transitions/view-transitions.php	Add `strict_types` declaration.
plugins/view-transitions/uninstall.php	Add `strict_types` declaration.
plugins/view-transitions/includes/theme.php	Add `strict_types` declaration.
plugins/view-transitions/includes/settings.php	Add `strict_types` declaration.
plugins/view-transitions/includes/functions.php	Add `strict_types` declaration.
plugins/view-transitions/includes/class-plvt-view-transition-animation.php	Add `strict_types` declaration.
plugins/view-transitions/includes/class-plvt-view-transition-animation-registry.php	Add `strict_types` declaration.
plugins/view-transitions/includes/admin.php	Add `strict_types` declaration.
plugins/view-transitions/hooks.php	Add `strict_types` declaration.
plugins/speculation-rules/wp-core-api.php	Add `strict_types` declaration.
plugins/speculation-rules/uninstall.php	Add `strict_types` declaration.
plugins/speculation-rules/settings.php	Add `strict_types` declaration.
plugins/speculation-rules/plugin-api.php	Add `strict_types` declaration.
plugins/speculation-rules/load.php	Add `strict_types` declaration.
plugins/speculation-rules/hooks.php	Add `strict_types` declaration.
plugins/speculation-rules/class-plsr-url-pattern-prefixer.php	Add `strict_types` declaration.
plugins/performance-lab/load.php	Add `strict_types` declaration.
plugins/performance-lab/includes/site-health/webp-support/hooks.php	Add `strict_types` declaration.
plugins/performance-lab/includes/site-health/webp-support/helper.php	Add `strict_types` declaration.
plugins/performance-lab/includes/site-health/load.php	Add `strict_types` declaration.
plugins/performance-lab/includes/site-health/effective-asset-cache-headers/hooks.php	Add `strict_types` declaration.
plugins/performance-lab/includes/site-health/effective-asset-cache-headers/helper.php	Add `strict_types` declaration.
plugins/performance-lab/includes/site-health/bfcache-compatibility-headers/hooks.php	Add `strict_types` declaration.
plugins/performance-lab/includes/site-health/bfcache-compatibility-headers/helper.php	Add `strict_types` declaration.
plugins/performance-lab/includes/site-health/avif-support/hooks.php	Add `strict_types` declaration.
plugins/performance-lab/includes/site-health/avif-support/helper.php	Add `strict_types` declaration.
plugins/performance-lab/includes/site-health/avif-headers/hooks.php	Add `strict_types` declaration.
plugins/performance-lab/includes/site-health/avif-headers/helper.php	Add `strict_types` declaration.
plugins/performance-lab/includes/site-health/audit-enqueued-assets/hooks.php	Add `strict_types` declaration.
plugins/performance-lab/includes/site-health/audit-enqueued-assets/helper.php	Add `strict_types` declaration.
plugins/performance-lab/includes/site-health/audit-autoloaded-options/hooks.php	Add `strict_types` declaration.
plugins/performance-lab/includes/site-health/audit-autoloaded-options/helper.php	Add `strict_types` declaration and ensure non-string option values are serialized before `strlen()`.
plugins/performance-lab/includes/server-timing/object-cache.copy.php	Add `strict_types` declaration.
plugins/performance-lab/includes/server-timing/load.php	Add `strict_types` declaration.
plugins/performance-lab/includes/server-timing/hooks.php	Add `strict_types` declaration.
plugins/performance-lab/includes/server-timing/defaults.php	Add `strict_types` declaration.
plugins/performance-lab/includes/server-timing/class-perflab-server-timing.php	Add `strict_types` declaration.
plugins/performance-lab/includes/server-timing/class-perflab-server-timing-metric.php	Add `strict_types` declaration.
plugins/performance-lab/includes/admin/server-timing.php	Add `strict_types` declaration.
plugins/performance-lab/includes/admin/rest-api.php	Add `strict_types` declaration.
plugins/performance-lab/includes/admin/plugins.php	Add `strict_types` declaration.
plugins/performance-lab/includes/admin/load.php	Add `strict_types` declaration.
plugins/optimization-detective/uninstall.php	Add `strict_types` declaration.
plugins/optimization-detective/storage/data.php	Add `strict_types` declaration.
plugins/optimization-detective/storage/class-od-url-metrics-post-type.php	Add `strict_types` declaration.
plugins/optimization-detective/storage/class-od-url-metric-store-request-context.php	Add `strict_types` declaration.
plugins/optimization-detective/storage/class-od-storage-lock.php	Add `strict_types` declaration.
plugins/optimization-detective/storage/class-od-rest-url-metrics-store-endpoint.php	Add `strict_types` declaration.
plugins/optimization-detective/site-health.php	Add `strict_types` declaration.
plugins/optimization-detective/optimization.php	Add `strict_types` declaration.
plugins/optimization-detective/load.php	Add `strict_types` declaration.
plugins/optimization-detective/hooks.php	Add `strict_types` declaration.
plugins/optimization-detective/helper.php	Add `strict_types` declaration.
plugins/optimization-detective/detection.php	Add `strict_types` declaration.
plugins/optimization-detective/deprecated.php	Add `strict_types` declaration.
plugins/optimization-detective/class-od-visited-tag-state.php	Add `strict_types` declaration.
plugins/optimization-detective/class-od-url-metric.php	Add `strict_types` declaration.
plugins/optimization-detective/class-od-url-metric-group.php	Add `strict_types` declaration.
plugins/optimization-detective/class-od-url-metric-group-collection.php	Add `strict_types` declaration.
plugins/optimization-detective/class-od-template-optimization-context.php	Add `strict_types` declaration.
plugins/optimization-detective/class-od-tag-visitor-registry.php	Add `strict_types` declaration.
plugins/optimization-detective/class-od-tag-visitor-context.php	Add `strict_types` declaration.
plugins/optimization-detective/class-od-strict-url-metric.php	Add `strict_types` declaration.
plugins/optimization-detective/class-od-link-collection.php	Add `strict_types` declaration.
plugins/optimization-detective/class-od-html-tag-processor.php	Add `strict_types` declaration.
plugins/optimization-detective/class-od-element.php	Add `strict_types` declaration.
plugins/optimization-detective/class-od-data-validation-exception.php	Add `strict_types` declaration.
plugins/image-prioritizer/load.php	Add `strict_types` declaration.
plugins/image-prioritizer/hooks.php	Add `strict_types` declaration.
plugins/image-prioritizer/helper.php	Add `strict_types` declaration.
plugins/image-prioritizer/class-image-prioritizer-video-tag-visitor.php	Add `strict_types` declaration.
plugins/image-prioritizer/class-image-prioritizer-tag-visitor.php	Add `strict_types` declaration.
plugins/image-prioritizer/class-image-prioritizer-img-tag-visitor.php	Add `strict_types` declaration.
plugins/image-prioritizer/class-image-prioritizer-background-image-styled-tag-visitor.php	Add `strict_types` declaration.
plugins/embed-optimizer/load.php	Add `strict_types` declaration.
plugins/embed-optimizer/hooks.php	Add `strict_types` declaration.
plugins/embed-optimizer/helper.php	Add `strict_types` declaration.
plugins/embed-optimizer/class-embed-optimizer-tag-visitor.php	Add `strict_types` declaration.
plugins/dominant-color-images/load.php	Add `strict_types` declaration.
plugins/dominant-color-images/hooks.php	Add `strict_types` declaration.
plugins/dominant-color-images/helper.php	Add `strict_types` declaration.
plugins/dominant-color-images/class-dominant-color-image-editor-imagick.php	Add `strict_types` declaration.
plugins/dominant-color-images/class-dominant-color-image-editor-gd.php	Add `strict_types` declaration.
plugins/auto-sizes/hooks.php	Add `strict_types` declaration.
plugins/auto-sizes/auto-sizes.php	Add `strict_types` declaration.
performance.php	Add `strict_types` declaration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

westonruter · 2026-04-02T06:25:38Z

@mukeshpanchal27 Are you having trouble running PHPUnit locally?

I'm trying npm run test-php:auto-sizes and I see:

npm run test-php:auto-sizes
Protected by Socket Firewall

> test-php:auto-sizes
> wp-env run tests-cli --env-cwd=/var/www/html/wp-content/plugins/performance composer test:auto-sizes

ℹ Starting 'composer test:auto-sizes' on the tests-cli container. 

Composer could not detect the root package (wordpress/performance) version, defaulting to '1.0.0'. See https://getcomposer.org/root-version
PHPUnit 10.5.60 by Sebastian Bergmann and contributors.

Unknown option "--verbose"
Script phpunit --strict-coverage handling the test event returned with error code 2
Script @test --verbose --testsuite auto-sizes was called via test:auto-sizes
✖ Command failed with exit code 2

This used to work.

See #2437

Add declare( strict_types = 1 ) to all PHP files

a07e94d

meravi requested review from adamsilverstein, b1ink0, mukeshpanchal27 and westonruter as code owners March 20, 2026 20:09

mukeshpanchal27 reviewed Mar 24, 2026

View reviewed changes

Move strict types declaration after plugin header

9992f0b

westonruter added the [Type] Enhancement A suggestion for improvement of an existing feature label Mar 24, 2026

westonruter added this to the performance-lab n.e.x.t milestone Mar 24, 2026

westonruter reviewed Mar 24, 2026

View reviewed changes

westonruter requested changes Mar 24, 2026

View reviewed changes

meravi added 3 commits March 25, 2026 09:33

Fix strict_types declaration placement and PHPCS issue

d011161

Remove strict_types from auto-sizes entry files

ec38bb6

Keep strict_types only in class files

773ce2d

meravi added 2 commits March 25, 2026 11:55

Revert "Keep strict_types only in class files"

fc8721e

This reverts commit 773ce2d.

Revert "Remove strict_types from auto-sizes entry files"

b4b053e

This reverts commit ec38bb6.

meravi requested a review from westonruter March 25, 2026 08:50

westonruter marked this pull request as draft March 25, 2026 22:54

Fix strict types handling for autoload options size query

1b25236

westonruter reviewed Mar 26, 2026

View reviewed changes

Comment thread plugins/performance-lab/includes/site-health/audit-autoloaded-options/helper.php Outdated

westonruter reviewed Mar 26, 2026

View reviewed changes

Comment thread plugins/performance-lab/includes/site-health/audit-autoloaded-options/helper.php Outdated

westonruter reviewed Mar 26, 2026

View reviewed changes

Comment thread plugins/performance-lab/includes/site-health/audit-autoloaded-options/helper.php Outdated

Update plugins/performance-lab/includes/site-health/audit-autoloaded-…

06783fa

…options/helper.php Co-authored-by: Weston Ruter <westonruter@gmail.com>

meravi and others added 3 commits March 26, 2026 10:53

Update plugins/performance-lab/includes/site-health/audit-autoloaded-…

eed4772

…options/helper.php Co-authored-by: Weston Ruter <westonruter@gmail.com>

Update plugins/performance-lab/includes/site-health/audit-autoloaded-…

b01a800

…options/helper.php Co-authored-by: Weston Ruter <westonruter@gmail.com>

Merge branch 'trunk' into add-strict-types

3b461d2

mukeshpanchal27 marked this pull request as ready for review March 26, 2026 05:20

mukeshpanchal27 approved these changes Mar 26, 2026

View reviewed changes

mukeshpanchal27 requested a review from westonruter April 2, 2026 04:07

westonruter requested a review from Copilot April 2, 2026 05:53

Copilot started reviewing on behalf of westonruter April 2, 2026 05:54 View session

Copilot AI reviewed Apr 2, 2026

View reviewed changes

Add strict_types to improve-calculate-sizes.php

849447a

westonruter approved these changes Apr 2, 2026

View reviewed changes

westonruter merged commit 58c9063 into WordPress:trunk Apr 2, 2026
31 checks passed

westonruter mentioned this pull request Apr 2, 2026

Fix static type error in REST API endpoint and add Generic.PHP.RequireStrictTypes to PHPCS ruleset #2436

Merged

Conversation

meravi commented Mar 20, 2026

Uh oh!

github-actions bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

meravi commented Mar 24, 2026

Uh oh!

mukeshpanchal27 Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

meravi Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

westonruter Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

westonruter left a comment

Choose a reason for hiding this comment

Uh oh!

westonruter commented Mar 25, 2026

Uh oh!

codecov bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

meravi commented Mar 25, 2026

Uh oh!

westonruter commented Mar 25, 2026

Uh oh!

meravi commented Mar 26, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

westonruter commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Mar 20, 2026 •

edited

Loading

codecov bot commented Mar 25, 2026 •

edited

Loading

westonruter commented Apr 2, 2026 •

edited

Loading