Skip to content

Fix: add missing sanitize_text_field() on provider input in login_form_validate_2fa() #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thisismyurl wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −2
Open

Fix: add missing sanitize_text_field() on provider input in login_form_validate_2fa() #899

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfc67c0
Fix: add missing sanitize_text_field() on provider input in login_for…
thisismyurl Jun 8, 2026
0bf501d
fix: sanitize provider as class-name identifier, not free-form text
thisismyurl Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions class-two-factor-core.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1560,7 +1560,7 @@ public static function rest_api_can_edit_user_and_update_two_factor_options( $us
public static function login_form_validate_2fa() {
$wp_auth_id = ! empty( $_REQUEST['wp-auth-id'] ) ? absint( $_REQUEST['wp-auth-id'] ) : 0;
$nonce = ! empty( $_REQUEST['wp-auth-nonce'] ) ? wp_unslash( $_REQUEST['wp-auth-nonce'] ) : '';
$provider = ! empty( $_REQUEST['provider'] ) ? wp_unslash( $_REQUEST['provider'] ) : '';
$provider = ! empty( $_REQUEST['provider'] ) ? preg_replace( '/[^a-zA-Z0-9_]/', '', wp_unslash( $_REQUEST['provider'] ) ) : '';
$redirect_to = ! empty( $_REQUEST['redirect_to'] ) ? wp_unslash( $_REQUEST['redirect_to'] ) : '';
$is_post_request = ( 'POST' === strtoupper( $_SERVER['REQUEST_METHOD'] ) );
$user = get_user_by( 'id', $wp_auth_id );
Expand Down Expand Up @@ -1700,7 +1700,7 @@ public static function _login_form_validate_2fa( $user, $nonce = '', $provider =
*/
public static function login_form_revalidate_2fa() {
$nonce = ! empty( $_REQUEST['wp-auth-nonce'] ) ? wp_unslash( $_REQUEST['wp-auth-nonce'] ) : '';
$provider = ! empty( $_REQUEST['provider'] ) ? sanitize_text_field( wp_unslash( $_REQUEST['provider'] ) ) : false;
$provider = ! empty( $_REQUEST['provider'] ) ? preg_replace( '/[^a-zA-Z0-9_]/', '', wp_unslash( $_REQUEST['provider'] ) ) : false;
$redirect_to = ! empty( $_REQUEST['redirect_to'] ) ? wp_unslash( $_REQUEST['redirect_to'] ) : admin_url();
$is_post_request = ( 'POST' === strtoupper( $_SERVER['REQUEST_METHOD'] ) );

Expand Down
Loading