Skip to content

tests: add coverage for provider-specific fallback notices (#855)#923

Open
dknauss wants to merge 1 commit into
WordPress:masterfrom
dknauss:pr-858-tests
Open

tests: add coverage for provider-specific fallback notices (#855)#923
dknauss wants to merge 1 commit into
WordPress:masterfrom
dknauss:pr-858-tests

Conversation

@dknauss

@dknauss dknauss commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Follow-up tests for PR #858, which landed without test coverage.

What

Two tests for the conditional notice logic introduced in #858:

  • test_user_two_factor_options_mentions_recovery_codes_when_backup_codes_are_available — when Two_Factor_Backup_Codes is registered, the profile UI should name "Recovery Codes" specifically
  • test_user_two_factor_options_uses_generic_wording_when_backup_codes_are_filtered_out — when Two_Factor_Backup_Codes is removed via the two_factor_providers filter, the UI should use the generic fallback wording instead

Also adds two private helpers used by these tests (and available for future notice-related tests):

  • reset_profile_errors() — clears the static $profile_errors array between tests via reflection
  • render_user_two_factor_options() — captures user_two_factor_options() output to a string

Why

The fix in #858 is a conditional: one branch names "Recovery Codes" explicitly, the other uses generic wording. Without tests, either branch could silently regress. These tests pin both sides of the condition.

🤖 Assisted by Claude Code

Open WordPress Playground Preview

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dknauss <dpknauss@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant