tests: add coverage for provider-specific fallback notices (#855)#923
Open
dknauss wants to merge 1 commit into
Open
tests: add coverage for provider-specific fallback notices (#855)#923dknauss wants to merge 1 commit into
dknauss wants to merge 1 commit into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up tests for PR #858, which landed without test coverage.
What
Two tests for the conditional notice logic introduced in #858:
test_user_two_factor_options_mentions_recovery_codes_when_backup_codes_are_available— whenTwo_Factor_Backup_Codesis registered, the profile UI should name "Recovery Codes" specificallytest_user_two_factor_options_uses_generic_wording_when_backup_codes_are_filtered_out— whenTwo_Factor_Backup_Codesis removed via thetwo_factor_providersfilter, the UI should use the generic fallback wording insteadAlso adds two private helpers used by these tests (and available for future notice-related tests):
reset_profile_errors()— clears the static$profile_errorsarray between tests via reflectionrender_user_two_factor_options()— capturesuser_two_factor_options()output to a stringWhy
The fix in #858 is a conditional: one branch names "Recovery Codes" explicitly, the other uses generic wording. Without tests, either branch could silently regress. These tests pin both sides of the condition.
🤖 Assisted by Claude Code