Block Processor: Fix is_block_type() for inner HTML #10701
Closed
+110
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
dmsnell
force-pushed
the
blocks/fix-block-processor-bug-inner-html-block-type
branch
3 times, most recently
from
03e4467 to
bf96baa
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Previously, the WP_Block_Processor class was making a mistake in mis-reporting whether a token matches a block type when #innerHTML spans are involved. This patch fixes the logic, which was originally written before a distinction between inner HTML and top-level freeform content was built.
dmsnell
force-pushed
the
blocks/fix-block-processor-bug-inner-html-block-type
branch
from
bf96baa to
9857326
Compare
pento
pushed a commit
that referenced
this pull request
Jan 8, 2026
Previously, the WP_Block_Processor class was making a mistake in mis-reporting whether a token matches a block type when #innerHTML spans are involved. This patch fixes the logic, which was originally written before a distinction between inner HTML and top-level freeform content was built. Developed in #10701 Discussed in https://core.trac.wordpress.org/ticket/64485 Fixes #64485. git-svn-id: https://develop.svn.wordpress.org/trunk@61452 602fd350-edb4-49c9-b593-d223f7449a82
dmsnell
deleted the
blocks/fix-block-processor-bug-inner-html-block-type
branch
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Jan 8, 2026
Previously, the WP_Block_Processor class was making a mistake in mis-reporting whether a token matches a block type when #innerHTML spans are involved. This patch fixes the logic, which was originally written before a distinction between inner HTML and top-level freeform content was built. Developed in WordPress/wordpress-develop#10701 Discussed in https://core.trac.wordpress.org/ticket/64485 Fixes #64485. Built from https://develop.svn.wordpress.org/trunk@61452 git-svn-id: http://core.svn.wordpress.org/trunk@60764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Jan 8, 2026
Previously, the WP_Block_Processor class was making a mistake in mis-reporting whether a token matches a block type when #innerHTML spans are involved. This patch fixes the logic, which was originally written before a distinction between inner HTML and top-level freeform content was built. Developed in WordPress/wordpress-develop#10701 Discussed in https://core.trac.wordpress.org/ticket/64485 Fixes #64485. Built from https://develop.svn.wordpress.org/trunk@61452 git-svn-id: https://core.svn.wordpress.org/trunk@60764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: Core-64485
Status
Summary
Previously, the
WP_Block_Processorclass was making a mistake in mis-reporting whether a token matches a block type when#innerHTMLspans are involved.This patch fixes the logic, which was originally written before a distinction between inner HTML and top-level freeform content was built.