Skip to content

Toolbar: Increase admin bar height to 48px for desktop and mobile #13234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dilipom13 wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Toolbar: Increase admin bar height to 48px for desktop and mobile #13234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/wp-admin/css/themes.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ body.js .theme-browser.search-loading {
background: #f0f0f1;
background: rgba(240, 240, 241, 0.9);
z-index: 10000; /* Over WP Pointers. */
min-height: calc(100vh - var(--wp-admin--admin-bar--height, 32px));
min-height: calc(100vh - var(--wp-admin--admin-bar--height, 48px));
}

.theme-overlay .theme-header {
Expand Down
16 changes: 8 additions & 8 deletions src/wp-content/themes/twentytwenty/style-rtl.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -965,13 +965,13 @@ th {
}

.admin-bar .screen-height {
min-height: calc(100vh - 32px);
min-height: calc(100vh - 48px);
}

@media (max-width: 782px) {

.admin-bar .screen-height {
min-height: calc(100vh - 46px);
min-height: calc(100vh - 48px);
}
}

Expand Down Expand Up @@ -1461,13 +1461,13 @@ body:not(.enable-search-modal) .site-logo img {
}

.admin-bar.overlay-header #site-header {
top: 32px;
top: 48px;
}

@media (max-width: 782px) {

.admin-bar.overlay-header #site-header {
top: 46px;
top: 48px;
}
}

Expand Down Expand Up @@ -1817,13 +1817,13 @@ body.touch-enabled .primary-menu ul li.menu-item-has-children > a {
}

.admin-bar .menu-modal {
top: 32px;
top: 48px;
}

@media (max-width: 782px) {

.admin-bar .menu-modal {
top: 46px;
top: 48px;
}
}

Expand Down Expand Up @@ -2091,13 +2091,13 @@ button.sub-menu-toggle.active svg {
}

.admin-bar .search-modal.active {
top: 32px;
top: 48px;
}

@media (max-width: 782px) {

.admin-bar .search-modal.active {
top: 46px;
top: 48px;
}
}

Expand Down
16 changes: 8 additions & 8 deletions src/wp-content/themes/twentytwenty/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -971,13 +971,13 @@ th {
}

.admin-bar .screen-height {
min-height: calc(100vh - 32px);
min-height: calc(100vh - 48px);
}

@media (max-width: 782px) {

.admin-bar .screen-height {
min-height: calc(100vh - 46px);
min-height: calc(100vh - 48px);
}
}

Expand Down Expand Up @@ -1467,13 +1467,13 @@ body:not(.enable-search-modal) .site-logo img {
}

.admin-bar.overlay-header #site-header {
top: 32px;
top: 48px;
}

@media (max-width: 782px) {

.admin-bar.overlay-header #site-header {
top: 46px;
top: 48px;
}
}

Expand Down Expand Up @@ -1825,13 +1825,13 @@ body.touch-enabled .primary-menu ul li.menu-item-has-children > a {
}

.admin-bar .menu-modal {
top: 32px;
top: 48px;
}

@media (max-width: 782px) {

.admin-bar .menu-modal {
top: 46px;
top: 48px;
}
}

Expand Down Expand Up @@ -2099,13 +2099,13 @@ button.sub-menu-toggle.active svg {
}

.admin-bar .search-modal.active {
top: 32px;
top: 48px;
}

@media (max-width: 782px) {

.admin-bar .search-modal.active {
top: 46px;
top: 48px;
}
}

Expand Down
4 changes: 2 additions & 2 deletions src/wp-content/themes/twentytwentyone/assets/css/style-editor.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,12 +219,12 @@
}

.admin-bar {
--global--admin-bar--height: 32px;
--global--admin-bar--height: 48px;
}
@media only screen and (max-width: 782px) {

.admin-bar {
--global--admin-bar--height: 46px;
--global--admin-bar--height: 48px;
}
}

Expand Down
4 changes: 2 additions & 2 deletions src/wp-content/themes/twentytwentyone/assets/sass/01-settings/global.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,10 +230,10 @@ $baseline-unit: 10px;
}

.admin-bar {
--global--admin-bar--height: 32px;
--global--admin-bar--height: 48px;

@media only screen and (max-width: 782px) {
--global--admin-bar--height: 46px;
--global--admin-bar--height: 48px;
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/wp-content/themes/twentytwentyone/classes/class-twenty-twenty-one-dark-mode.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ public function the_html( $attrs = array() ) {
}
@media only screen and (max-width: 782px) {
#dark-mode-toggler {
margin-top: 32px;
margin-top: 48px;
}
}
<?php endif; ?>
Expand Down
4 changes: 2 additions & 2 deletions src/wp-content/themes/twentytwentyone/style-rtl.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,12 +311,12 @@ Twenty Twenty-One is distributed under the terms of the GNU GPL.
}

.admin-bar {
--global--admin-bar--height: 32px;
--global--admin-bar--height: 48px;
}
@media only screen and (max-width: 782px) {

.admin-bar {
--global--admin-bar--height: 46px;
--global--admin-bar--height: 48px;
}
}

Expand Down
4 changes: 2 additions & 2 deletions src/wp-content/themes/twentytwentyone/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,12 +311,12 @@ Twenty Twenty-One is distributed under the terms of the GNU GPL.
}

.admin-bar {
--global--admin-bar--height: 32px;
--global--admin-bar--height: 48px;
}
@media only screen and (max-width: 782px) {

.admin-bar {
--global--admin-bar--height: 46px;
--global--admin-bar--height: 48px;
}
}

Expand Down
3 changes: 1 addition & 2 deletions src/wp-includes/admin-bar.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1390,8 +1390,7 @@ function wp_enqueue_admin_bar_bump_styles() {
remove_action( 'wp_head', $header_callback );

$css = '
@media screen { html { margin-top: 32px !important; } }
@media screen and ( max-width: 782px ) { html { margin-top: 46px !important; } }
@media screen { html { margin-top: 48px !important; } }
';
wp_add_inline_style( 'admin-bar', $css );
}
Expand Down
Loading
Loading