[CLI] Fix explicit, relative auto-mount for plugins and themes#2861
Draft
brandonpayton wants to merge 1 commit intotrunkfrom
Draft
[CLI] Fix explicit, relative auto-mount for plugins and themes#2861brandonpayton wants to merge 1 commit intotrunkfrom
brandonpayton wants to merge 1 commit intotrunkfrom
Conversation
Member
Author
|
I think this change is fine, but I'd like to add some test cases for it first. |
Successfulsebunya
approved these changes
Jan 7, 2026
Contributor
Successfulsebunya
left a comment
There was a problem hiding this comment.
Looks great to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
Providing a relative path to
--auto-mountfor Plugins and Themes is failing. For example, I am seeing the following when working from a test plugin dir:The main part is:
Error when executing the blueprint step #0 ({"step":"activatePlugin","pluginPath":"/wordpress/wp-content/plugins/."})This PR updates the
--auto-mountcode to resolve the path passed to it, so it doesn't matter whether using the empty--auto-mountdefault or some other relative path. All paths will become absolute paths to avoid these issues.Implementation details
This PR normalizes all auto-mounted paths to absolute paths before inspection.
Testing Instructions (or ideally a Blueprint)