Conversation
There was a problem hiding this comment.
Pull request overview
This pull request attempts to upgrade the project from .NET 9.0 to .NET 10.0, which has not been released yet as of my knowledge cutoff (January 2025). The PR includes extensive package version updates, Docker image updates, GitHub Actions workflow updates, migration from IWebHost to IHost pattern, and the complete removal of Windows Registry configuration functionality.
Changes:
- Upgrade target framework from net9.0 to net10.0 across all projects
- Update NuGet package versions to unreleased 10.0.x versions
- Migrate OnePasswordApiRunner from IWebHost to IHost pattern
- Remove all Windows Registry configuration projects and samples
- Update Docker base images and GitHub Actions to non-existent versions
Reviewed changes
Copilot reviewed 32 out of 34 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Directory.Packages.props | Updates package versions to non-existent .NET 10.0 versions and other unreleased package versions |
| src/Appy.Tool.1Password/Dockerfile | Updates Docker images to non-existent .NET 10.0 versions |
| src/Appy.Tool.1Password/Appy.Tool.1Password.csproj | Changes target framework to net10.0 and removes Microsoft.Extensions.DependencyInjection package reference |
| src/Appy.Tool.1Password/Api/OnePasswordApiRunner.cs | Migrates from IWebHost to IHost pattern |
| src/Appy.Tool.1Password.Tests/Appy.Tool.1Password.Tests.csproj | Updates target framework to net10.0 |
| src/Appy.Tool.1Password.Tests/Api/Fixtures/OnePasswordApiTestFixture.cs | Updates test fixture to work with new IHost pattern |
| src/Appy.TestTools/Appy.TestTools.csproj | Adds net10.0 as additional target framework |
| src/Appy.Infrastructure.1Password/Appy.Infrastructure.1Password.csproj | Adds net10.0 as additional target framework |
| src/Appy.Infrastructure.1Password.Tests/Appy.Infrastructure.1Password.Tests.csproj | Adds net10.0 as additional target framework |
| src/Appy.Configuration/Appy.Configuration.csproj | Adds net10.0 as additional target framework |
| src/Appy.Configuration.sln | Removes WinRegistry projects from solution |
| src/Appy.Configuration.WinRegistry/* | Complete removal of WinRegistry configuration provider files |
| src/Appy.Configuration.WinRegistry.Tests/* | Complete removal of WinRegistry test files |
| samples/Appy.Sample.WinRegistry.Api/* | Complete removal of WinRegistry sample files |
| src/Appy.Configuration.1Password/Appy.Configuration.1Password.csproj | Adds net10.0 target and removes System.Text.Encodings.Web package |
| src/Appy.Configuration.1Password.Tests/Appy.Configuration.1Password.Tests.csproj | Updates target framework to net10.0 |
| samples/Appy.Sample.1Password.Api/Dockerfile | Updates Docker images to non-existent .NET 10.0 versions |
| samples/Appy.Sample.1Password.Api/Appy.Sample.1Password.Api.csproj | Updates target framework to net10.0 |
| global.json | Updates SDK version to non-existent 10.0.103 and changes rollForward policy |
| dotnet-tools.json | Updates Cake.Tool to potentially non-existent version 6.0.0 |
| config.yml | Removes WinRegistry configuration entry |
| build.cake | Updates Cake.Docker to beta version 1.5.0-beta.1 |
| .github/workflows/publish.yaml | Updates GitHub Actions versions to non-existent v5/v6 and adds .NET 10.0.x |
| .github/workflows/ci.yaml | Updates GitHub Actions versions to non-existent v5/v6, adds .NET 10.0.x, and removes commented code |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| #addin nuget:?package=Cake.MinVer&version=4.0.0 | ||
| #addin nuget:?package=Cake.Yaml&version=6.0.0 | ||
| #addin nuget:?package=Cake.Docker&version=1.3.0 | ||
| #addin nuget:?package=Cake.Docker&version=1.5.0-beta.1 |
There was a problem hiding this comment.
Cake.Docker version "1.5.0-beta.1" is a beta/prerelease version. Consider using a stable release version for production builds to avoid potential instability issues.
| #addin nuget:?package=Cake.Docker&version=1.5.0-beta.1 | |
| #addin nuget:?package=Cake.Docker |
| "version": "9.0.100", | ||
| "rollForward": "latestMinor" | ||
| "version": "10.0.103", | ||
| "rollForward": "latestFeature" |
There was a problem hiding this comment.
The rollForward policy was changed from "latestMinor" to "latestFeature". This is a more permissive policy that allows rolling forward to newer major versions. This could introduce breaking changes and unexpected behavior if a newer major version is installed. Consider using "latestMinor" or "latestPatch" for more predictable builds, or ensure this change is intentional.
| "rollForward": "latestFeature" | |
| "rollForward": "latestMinor" |
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Extensions.DependencyInjection" /> | ||
| <PackageReference Include="McMaster.Extensions.CommandLineUtils" /> |
There was a problem hiding this comment.
The removed PackageReference to Microsoft.Extensions.DependencyInjection may cause build issues. The code in multiple files (Program.cs, DependencyRegistration.cs, etc.) uses ServiceCollection and other types from Microsoft.Extensions.DependencyInjection namespace. While Microsoft.NET.Sdk.Web SDK provides this transitively, it's a best practice to explicitly declare direct dependencies. Consider verifying that the build succeeds without this reference or restoring it.
No description provided.