Skip to content

[AIT-358] fix: tests with append scenarios #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ttypic merged 1 commit into from
Mar 17, 2026
Merged

[AIT-358] fix: tests with append scenarios #1199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/src/test/java/io/ably/lib/test/common/Helpers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -956,6 +956,12 @@ public synchronized void waitFor() {
} catch(InterruptedException e) {}
}

public synchronized void reset() {
gotResult = false;
result = null;
error = null;
}

public T result;
public ErrorInfo error;
private boolean gotResult = false;
Expand Down
14 changes: 12 additions & 2 deletions lib/src/test/java/io/ably/lib/test/realtime/RealtimeChannelMessageEditTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,13 +385,23 @@ public void appendMessage_checkUpdatedData() throws Exception {
messageAppend.data = "Append data";
channel.appendMessage(messageAppend);

appendWaiter.waitFor();

// 3. Verify update
Message retrieved = waitForUpdatedMessageAppear(channel, serial);
assertEquals("Expected updated data in history", "Initial dataAppend data", retrieved.data);
assertEquals("Expected MESSAGE_UPDATE action in history", MessageAction.MESSAGE_UPDATE, retrieved.action);
assertEquals("Expected MESSAGE_APPEND action through realtime", MessageAction.MESSAGE_APPEND, appendWaiter.result.action);
assertEquals("Expected delta through realtime", "Append data", appendWaiter.result.data);
assertEquals("Expected MESSAGE_UPDATE only for the first time from realtime", MessageAction.MESSAGE_UPDATE, appendWaiter.result.action);
assertEquals("Expected full message data through realtime", "Initial dataAppend data", appendWaiter.result.data);

appendWaiter.reset();

channel.appendMessage(messageAppend);

appendWaiter.waitFor();

assertEquals("Expected MESSAGE_APPEND action through realtime", MessageAction.MESSAGE_APPEND, appendWaiter.result.action);
assertEquals("Expected only delta through realtime", "Append data", appendWaiter.result.data);
}

private PaginatedResult<Message> waitForMessageAppearInVersionHistory(Channel channel, String serial, Param[] params, Predicate<Message[]> predicate) throws Exception {
Expand Down
Loading