fix: add transaction feedback toasts and trade panel error boundary (… - #739
Merged
Chucks1093 merged 1 commit intoJul 30, 2026
Conversation
Contributor
Author
|
Done, please review. |
Contributor
|
Good work |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #546
This PR introduces visual transaction feedback toasts following confirmed buy and sell trades, and wraps the trade panel in a React Error Boundary to isolate render errors without crashing the surrounding page.
Changes Made
Transaction Success Toasts:
Bought {n} key{s} from {creator}after a buy confirmation.Sold {n} key{s} from {creator}after a sell confirmation.1 keyvs2 keys).Trade Panel Error Boundary:
TradePanelErrorBoundaryclass component to catch unexpected render errors inside the trade dialog.Tests:
TradePanelErrorBoundary.test.tsxcovering normal child rendering, fallback UI on render error, layout isolation, and state reset on retry.LandingPage.tradeConfirmToast.integration.test.tsx,LandingPage.buyFlowEndToEnd.integration.test.tsx, andLandingPage.sellFlow.integration.test.tsxto verify new toast messages and boundary behaviors.How Has This Been Tested?
Ran local Vitest suite across target test files:
src/components/common/__tests__/TradePanelErrorBoundary.test.tsxsrc/pages/__tests__/LandingPage.tradeConfirmToast.integration.test.tsxsrc/pages/__tests__/LandingPage.buyFlowEndToEnd.integration.test.tsxsrc/pages/__tests__/LandingPage.sellFlow.integration.test.tsxAll 13 unit and integration tests passed cleanly.