chore: deploy HyperliquidDepositHandler after audit of Jan 19#1313
chore: deploy HyperliquidDepositHandler after audit of Jan 19#1313grasphoper merged 6 commits intomasterfrom
HyperliquidDepositHandler after audit of Jan 19#1313Conversation
Signed-off-by: Ihor Farion <ihor@umaproject.org>
Signed-off-by: Ihor Farion <ihor@umaproject.org>
tbwebb22
left a comment
There was a problem hiding this comment.
looks like owner and signer are both currently the dev wallet - is this what we want?
|
@tbwebb22 yea that's fine for now. Once backend team is done with testing with these contracts, we can change signer to prod backend EOA first, then transfer ownership to a multisig; that's the plan |
When they do it and we change the singer / owner we can merge this, but for now can just stay as a PR |
Signed-off-by: Ihor Farion <ihor@umaproject.org>
| address spokePool = 0x35E63eA3eb0fb7A3bc543C71FB66412e1F6B0E04; | ||
| # signer defaults to deployer | ||
| forge script script/DeployHyperliquidDepositHandler.s.sol:DeployHyperliquidDepositHandler \ | ||
| --sig "run(string)" "$TOKENS_ENCODED" --rpc-url hyperevm -vvvv --broadcast --verify |
There was a problem hiding this comment.
could we just pass in the token array directly rather than having to encode it first? just make that arg a string[]?
eg
forge script ... --sig "run(string[])" '["usdt0","usdc","usdh"]'
Signed-off-by: Ihor Farion <ihor@umaproject.org>
Signed-off-by: Ihor Farion <ihor@umaproject.org>
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
Also fixes
HyperliquidDepositHandler's deployment scriptCloses ACP-53