Skip to content

chore: deploy HyperliquidDepositHandler after audit of Jan 19#1313

Merged
grasphoper merged 6 commits intomasterfrom
if/hldeposithandler-afterauditjan19
Mar 25, 2026
Merged

chore: deploy HyperliquidDepositHandler after audit of Jan 19#1313
grasphoper merged 6 commits intomasterfrom
if/hldeposithandler-afterauditjan19

Conversation

@grasphoper
Copy link
Copy Markdown
Collaborator

@grasphoper grasphoper commented Feb 13, 2026

Also fixes HyperliquidDepositHandler's deployment script

Closes ACP-53

Signed-off-by: Ihor Farion <ihor@umaproject.org>
@linear
Copy link
Copy Markdown

linear Bot commented Feb 13, 2026

Signed-off-by: Ihor Farion <ihor@umaproject.org>
Copy link
Copy Markdown
Contributor

@tbwebb22 tbwebb22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like owner and signer are both currently the dev wallet - is this what we want?

@grasphoper
Copy link
Copy Markdown
Collaborator Author

@tbwebb22 yea that's fine for now. Once backend team is done with testing with these contracts, we can change signer to prod backend EOA first, then transfer ownership to a multisig; that's the plan

@grasphoper
Copy link
Copy Markdown
Collaborator Author

@tbwebb22 yea that's fine for now. Once backend team is done with testing with these contracts, we can change signer to prod backend EOA first, then transfer ownership to a multisig; that's the plan

When they do it and we change the singer / owner we can merge this, but for now can just stay as a PR

Signed-off-by: Ihor Farion <ihor@umaproject.org>
fusmanii
fusmanii previously approved these changes Mar 25, 2026
address spokePool = 0x35E63eA3eb0fb7A3bc543C71FB66412e1F6B0E04;
# signer defaults to deployer
forge script script/DeployHyperliquidDepositHandler.s.sol:DeployHyperliquidDepositHandler \
--sig "run(string)" "$TOKENS_ENCODED" --rpc-url hyperevm -vvvv --broadcast --verify
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we just pass in the token array directly rather than having to encode it first? just make that arg a string[]?

eg
forge script ... --sig "run(string[])" '["usdt0","usdc","usdh"]'

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed efbf97d

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

tbwebb22
tbwebb22 previously approved these changes Mar 25, 2026
Signed-off-by: Ihor Farion <ihor@umaproject.org>
@grasphoper grasphoper dismissed stale reviews from tbwebb22 and fusmanii via 284eb50 March 25, 2026 17:43
Signed-off-by: Ihor Farion <ihor@umaproject.org>
@socket-security
Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn Critical
Critical CVE: npm form-data uses unsafe random function in form-data for choosing boundary

CVE: GHSA-fjxv-7rqg-78g4 form-data uses unsafe random function in form-data for choosing boundary (CRITICAL)

Affected versions: < 2.5.4; >= 3.0.0 < 3.0.4; >= 4.0.0 < 4.0.4

Patched version: 2.5.4

From: ?npm/form-data@2.5.1

ℹ Read more on: This package | This alert | What is a critical CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/form-data@2.5.1. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@grasphoper grasphoper requested review from fusmanii and tbwebb22 March 25, 2026 18:13
@grasphoper grasphoper merged commit 4b92181 into master Mar 25, 2026
14 checks passed
@grasphoper grasphoper deleted the if/hldeposithandler-afterauditjan19 branch March 25, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants