Conversation
auniverseaway
approved these changes
Dec 12, 2025
Member
auniverseaway
left a comment
auniverseaway
left a comment
There was a problem hiding this comment.
This works.
The likely better solution would be to not render the da-versions web component if its not the currently requested pane. Then you can avoid touching da-versions altogether and passing props. Pretty sure this was how it was done before I introduced this regression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Versions are loaded after document is opened. If no one clicks on the Version History button, this was useless. Number of clicks on the button is very low.
If a document has more than 500+ versions (including empty version files for edition tracking),
/versionlistfires more than 500 requests (get object, 500x get versionsource...)! It is pretty common that a document has more than 100 or 200 versions, especially documents with active authors...Delaying the version loading will save thousands of requests!!
I have added a nice "Loading..." experience.
Before: https://main--da-live--adobe.aem.live/edit#/auniverseaway/oh-demo/index
After: https://versions--da-live--adobe.aem.live/edit#/auniverseaway/oh-demo/index