Skip to content

Conversation

@lixiaoyan
Copy link
Contributor

@lixiaoyan lixiaoyan commented Dec 22, 2025

The purpose of this PR is to use virtual viewports as much as possible. This helps us to maintain consistency between browsers.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@snowystinger
Copy link
Member

The purpose of this PR is to use virtual viewports as much as possible. This helps us to maintain consistency between browsers.

Did you notice a discrepancy between browsers with this behaviour and if so, what was it? or is something misbehaving?

@lixiaoyan
Copy link
Contributor Author

The issue is that visualViewport.width may not be identical to either window.innerWidth or document.documentElement.clientWidth.
See: #9318 (comment)

@snowystinger
Copy link
Member

Thanks, so there are currently a lot of PRs open from you around this topic (much appreciated) and I'm unsure which ones I'm supposed to be reviewing and/or in what order. Additionally, many of them are missing tests or examples or test instructions where I can verify the behaviour before and after the change. I'm also finding it hard to determine each PR's motivation for being open. This makes them very challenging to review, would you mind consolidating the ones which are bugs vs the ones which are feature requests and adding that information to them?
Screenshot 2026-01-06 at 2 57 27 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants