fix: fix TableView from crashing when another collection is rendered as empty state#9557
Merged
fix: fix TableView from crashing when another collection is rendered as empty state#9557
Conversation
|
Build successful! 🎉 |
snowystinger
reviewed
Feb 6, 2026
| ]; | ||
| const renderEmptyState = () => ( | ||
| <Tabs aria-label="Settings"> | ||
| <CollectionRendererContext.Provider value={DefaultCollectionRenderer}> |
Member
There was a problem hiding this comment.
We'll want to delete this line, which should cause the test to fail.
Once that's verified, we'll want to add this line around the renderEmptyState call so that the rendered child doesn't pick up the wrong context
…ableView component
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
yihuiliao
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes <No issue created yet, can create one if needed>
✅ Pull Request Checklist:
📝 Test Instructions:
Just open the last story. Remove the extra
CollectionRendererContext.Providerwrapping the Tabs to see the original error.🧢 Your Project:
Quarry