Bump urllib3 to 2.7.0 (GHSA-mf9v-mfxr-j63j) - #126
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: adrienpessu <7055334+adrienpessu@users.noreply.github.com>
Co-authored-by: adrienpessu <7055334+adrienpessu@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix urllib3 decompression-bomb safeguards
Bump urllib3 to 2.7.0 (GHSA-mf9v-mfxr-j63j)
Sep 28, 2026
adrienpessu
marked this pull request as ready for review
September 28, 2026 07:29
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
|
@adrienpessu @felickz @GeekMasher Why am I receiving spam emails from this thread? I have nothing to do with your project. Please fix your CI (or whatever it is) as soon as possible! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pipfile.lockpinned urllib3 2.6.3, which is affected by GHSA-mf9v-mfxr-j63j / CVE-2026-44432 (high): decompression-bomb safeguards can be bypassed in the streaming API via incrementalread(amt=N)on Brotli-encoded responses and viadrain_conn()after partial decompression.Changes
Pipfile: added an expliciturllib3 = ">=2.7.0"lower bound (urllib3 was previously only transitive, viaghastoolkit→requests).Pipfile.lock: urllib32.6.3→2.7.0, produced withpipenv upgrade urllib3==2.7.0so no unrelated packages are bumped. A plainpipenv lockwould have moved ~12 other packages.Reachability assessment
Not reachable — high confidence. The advisory names specific APIs, and none are used here:
codeqlsummarize/ortests/importsurllib3orrequests, or performs HTTP requests; there are nostream=/read(amt=...)/drain_conn()call sites.requestsdoes not calldrain_conn(), and neitherbrotlinorbrotlicffiappears in the lock file, so the Brotli decoder path cannot be selected.The bump is therefore to clear the scanner alert rather than to close an actively exercised path.
Note for reviewers
black .reports formatting differences in 22 files that this PR does not touch — pre-existing and unrelated.Original prompt
This section details the Dependabot vulnerability alert you should resolve
<alert_title>urllib3: Decompression-bomb safeguards bypassed in parts of the streaming API</alert_title>
<alert_description>### Impact
urllib3's streaming API is designed for the efficient handling of large HTTP responses by reading the content in chunks, rather than loading the entire response body into memory at once.
urllib3 can perform decompression based on the HTTP
Content-Encodingheader (e.g.,gzip,deflate,br, orzstd). When using the streaming API since version 2.6.0, the library decompresses only the necessary bytes, enabling partial content consumption.However, urllib3 before version 2.7.0 could still decompress the whole response instead of the requested portion in two cases:
HTTPResponse.read(amt=N)call when the response was decompressed using the official Brotli library.HTTPResponse.drain_conn()was called after the response had been read and decompressed partially (compression algorithm did not matter here).These issues could cause urllib3 to fully decode a small amount of highly compressed data in a single operation. This could result in excessive resource consumption (high CPU usage and massive memory allocation for the decompressed data; CWE-409) on the client side.
Affected usages
Applications and libraries using urllib3 versions earlier than 2.7.0 may be affected when streaming compressed responses from untrusted sources in either of these cases, unless decompression is explicitly disabled:
bris read incrementally with at least twoHTTPResponse.read(amt=N)orHTTPResponse.stream(amt=N)calls while using the official Brotli library.HTTPResponse.drain_conn()is called after response decompression has already started.Remediation
Upgrade to at least urllib3 version 2.7.0 in which the library:
HTTPResponse.drain_conn().If upgrading is not immediately possible, the following workarounds may reduce exposure in specific cases:
output_buffer_limitis not fully respected google/brotli#1396.HTTPResponse.drain_conn(), callHTTPResponse.close()instead when connection reuse is not important.Credits
The Brotli-specific issue was reported by @kimkou2024.
HTTPResponse.drain_conn()inefficiency was reported by @Cycloctane.</alert_description>high
https://github.com/urllib3/urllib3/security/advisories/GHSA-mf9v-mfxr-j63j https://nvd.nist.gov/vuln/detail/CVE-2026-44432 https://github.com/pypa/advisory-database/tree/main/vulns/urllib3/PYSEC-2026-142.yaml https://github.com/advisories/GHSA-mf9v-mfxr-j63jGHSA-mf9v-mfxr-j63j, CVE-2026-44432
urllib3
pip
<vulnerable_versions>= 2.6.3</vulnerable_versions>
<patched_version>2.7.0</patched_version>
<manifest_path>Pipfile.lock</manifest_path>
<task_instructions>Resolve this alert by updating the affected package to a non-vulnerable version. Prefer the lowest non-vulnerable version (see the patched_version field above) over the latest to minimize breaking changes. Include a Reachability Assessment section in the PR description. Review the alert_description field to understand which APIs, features, or configurations are affected, then search the codebase for usage of those specific items. If the vulnerable code path is reachable, explain how (which files, APIs, or call sites use the affected functionality) and note that the codebase is actively exposed to this vulnerability. If the vulnerable code path is not reachable, explain why (e.g. the affected API is never called, the vulnerable configuration is not used) and note that the update is primarily to satisfy vulnerability scanners rather than to address an active risk. If the advisory is too vague to determine reachability (e.g. 'improper input validation' with no specific API named), state that reachability could not be determined and explain why. Include a confidence level in the reachability assessment (e.g. high confidence if the advisory names a specific API and you confirmed it is or is not called, low confidence if the usage is indirect and hard to trace). If no patched version is available, check the alert_description field for a Workarounds section — the advisory may describe configuration changes or usage patterns that mitigate the vulnerability without a version u...