[CLIENT-3914] Fix memory leak when aerospike.GeoJSON instance is used in an expression - #1157
Conversation
…ght come from negative codepath for geo_within_radius and geo_contains_point predicates
juliannguyen4
changed the base branch from
dev
to
CLIENT-3915-add-suppression-that-ignores-all-possibly-lost-or-reachable-stack-traces-without-client-lines
July 22, 2026 14:19
…hon client. C client doesn't doesn't have a helper function to clean up memory owned by as_exp_entry instances.
… Python client C code" This reverts commit 64f15d5.
…d by Python client. C client doesn't doesn't have a helper function to clean up memory owned by as_exp_entry instances." This reverts commit fdd0d5e.
…n as_exp_compile, so we revert the last two commits. But as_geojson values that use a heap allocated string need to set a different flag than as_val.free to clean up that string
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## CLIENT-3915-add-suppression-that-ignores-all-possibly-lost-or-reachable-stack-traces-without-client-lines #1157 +/- ##
==========================================================================================================================================
Coverage 85.38% 85.39%
==========================================================================================================================================
Files 101 101
Lines 14609 14614 +5
==========================================================================================================================================
+ Hits 12474 12479 +5
Misses 2135 2135 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…ost-or-reachable-stack-traces-without-client-lines' into jnguyen/CLIENT-3914-address-AerospikeGeospatial_DoDumps-memory-leak
…ost-or-reachable-stack-traces-without-client-lines' into jnguyen/CLIENT-3914-address-AerospikeGeospatial_DoDumps-memory-leak
…ost-or-reachable-stack-traces-without-client-lines' into jnguyen/CLIENT-3914-address-AerospikeGeospatial_DoDumps-memory-leak
…ost-or-reachable-stack-traces-without-client-lines' into jnguyen/CLIENT-3914-address-AerospikeGeospatial_DoDumps-memory-leak
juliannguyen4
marked this pull request as ready for review
July 27, 2026 17:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extra changes
Address potential memory leak when
geo_within_radiusandgeo_contains_pointpredicates raise an exception.TODO
If all definitely lost leaks are resolved, we do not need custom suppressions anymore.