Skip to content

Set explicit text color on dialog and buttons to prevent white-on-white with color-scheme dark#5814

Merged
dmarcos merged 1 commit into
aframevr:masterfrom
vincentfretin:set-dialog-color
May 21, 2026
Merged

Set explicit text color on dialog and buttons to prevent white-on-white with color-scheme dark#5814
dmarcos merged 1 commit into
aframevr:masterfrom
vincentfretin:set-dialog-color

Conversation

@vincentfretin
Copy link
Copy Markdown
Contributor

Description:

With color-scheme normal or light, you get
Capture d’écran du 2026-04-16 14-02-10
but the black text is from the browser default style.
When you switch to color-scheme: dark for example with

<style>
:root {
  color-scheme: dark;
}
</style>

you get white on white
Capture d’écran du 2026-04-16 14-02-37

and with inspector open you get
Capture d’écran du 2026-04-16 14-02-43
because color come from the body.aframe-inspector-opened rule.

Changes proposed:

  • Define text color explicitly for a-dialog and a-button so we have the first image with color-scheme dark.

…te with color-scheme dark

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@dmarcos dmarcos merged commit fc138fe into aframevr:master May 21, 2026
1 check passed
@vincentfretin vincentfretin deleted the set-dialog-color branch May 22, 2026 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants