Skip to content

fix(acp): bound newline-delimited input frames - #341

Open
fontanierh wants to merge 2 commits into
agentclientprotocol:mainfrom
fontanierh:fix/bounded-acp-stdout
Open

fix(acp): bound newline-delimited input frames#341
fontanierh wants to merge 2 commits into
agentclientprotocol:mainfrom
fontanierh:fix/bounded-acp-stdout

Conversation

@fontanierh

@fontanierh fontanierh commented Aug 27, 2026

Copy link
Copy Markdown

Closes #340. Closes #342.

AcpAgent child stdout ─┐
Stdio stdin            ├─▶ bounded reader (16 MiB default / override) ─▶ JSON-RPC
ByteStreams input      ┘
                                  │ oversize
                                  └─▶ InvalidData / transport cleanup

One shared reader bounds memory before UTF-8 and JSON parsing while preserving exact-limit, CRLF and EOF behavior.

Validation: just test; core all-feature Clippy with -D warnings.

@fontanierh fontanierh changed the title fix(acp): bound agent stdout frames fix(acp): bound newline-delimited input frames Aug 27, 2026
@fontanierh fontanierh reopened this Aug 27, 2026
@fontanierh fontanierh reopened this Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stdio and ByteStreams buffer unbounded incoming lines AcpAgent stdout lines are unbounded before JSON-RPC parsing

1 participant