docs(ack-pay): align receipt API examples#89
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThis pull request updates documentation for the ACK receipt payment verification feature. The credential type example is changed from ChangesACK Receipt Verification Documentation
🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
trustedReceiptIssuers, matching the exportedverifyPaymentReceiptoptionsisPaymentReceiptClaimand import the exported receipt credential guardPaymentReceiptCredentialWhy
The README currently shows
trustedIssuers, butverifyPaymentReceiptacceptstrustedReceiptIssuers. It also referencesisPaymentReceiptClaim, which is internal toreceipt-claim-verifier.tsand is not exported from@agentcommercekit/ack-pay.Verification
corepack pnpm install --frozen-lockfilecorepack pnpm check:formatgit diff --checkcorepack pnpm --filter @agentcommercekit/ack-pay check:typesinitially failed because workspace package exports resolve from builtdistoutputscorepack pnpm --filter @agentcommercekit/ack-pay... buildcorepack pnpm --filter @agentcommercekit/ack-pay check:typesNotes
This is docs-only and avoids the receipt verification logic changed in #88.
Summary by CodeRabbit
Documentation
PaymentReceiptCredential) and trust configuration patterns withtrustedReceiptIssuers