feat(server): bound database connection pool#236
Draft
abhinav-galileo wants to merge 4 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
abhinav-galileo
force-pushed
the
abhi/agent-control-db-pooling
branch
from
54d842f to
ed28d63
Compare
abhinav-galileo
changed the title
- bound connection establishment and per-statement runtime at the driver level for non-SQLite URLs (psycopg and asyncpg) - default AGENT_CONTROL_DB_MAX_OVERFLOW to 10 so short bursts borrow transient connections instead of failing after the pool timeout - initialize the checked-out-connections gauge so idle processes report 0 instead of an absent series
abhinav-galileo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Defaults
AGENT_CONTROL_DB_POOL_SIZE=5AGENT_CONTROL_DB_MAX_OVERFLOW=10AGENT_CONTROL_DB_POOL_TIMEOUT_SECONDS=5.0AGENT_CONTROL_DB_CONNECT_TIMEOUT_SECONDS=5AGENT_CONTROL_DB_STATEMENT_TIMEOUT_SECONDS=50.0Verification
uv run --package agent-control-server ruff check --config pyproject.toml server/src server/tests/test_config.py server/tests/test_db.py server/tests/test_evaluation_error_handling.pyuv run --package agent-control-server mypy --config-file pyproject.toml server/src