feat(monitor): unify explorer/trainer wandb logging into one run#590
Open
MengsD wants to merge 1 commit into
Open
feat(monitor): unify explorer/trainer wandb logging into one run#590MengsD wants to merge 1 commit into
MengsD wants to merge 1 commit into
Conversation
When monitor.monitor_type is wandb and monitor.shared_run is True, explorer and trainer log their metrics to the same run; metrics are labelled by {role}/step.
Collaborator
Author
|
/unittest-diff |
unittest: Run #1780
🎉 All tests passed!Github Test Reporter by CTRF 💚 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When monitor.monitor_type is wandb and monitor.shared_run is True, explorer and trainer log their metrics to the same run; metrics are labelled by {role}/step.
Description
[Please describe the background, purpose, changes made, and how to test this PR]
Background
Closes #556
Why this design
A wandb run has a single global _step — a per-run counter assigned in arrival order. With two roles writing one shared run, their rows interleave, so each role lands on a gapped _step (e.g. explorer 0,2,4…, trainer 1,3,5…) and can't show a clean 1..N. The only fix is to give each metric its own x-axis via define_metric(key, step_metric="{role}/step").
Three constraints then shaped the implementation:
Approach: make every writer carry the full binding set, so no sync can drop anything.
Changes made
How to test
monitor:
monitor_type: wandb
shared_run: true
Checklist
Please check the following items before code is ready to be reviewed.