Open
Conversation
RWezeman
reviewed
Dec 28, 2024
RWezeman
left a comment
There was a problem hiding this comment.
Cool work. 3D detection seems not yet optimal but might have to play a bit more around with it.
Some suggestions I had to try to get your code to work
Co-authored-by: RWezeman <39837929+RWezeman@users.noreply.github.com>
Co-authored-by: RWezeman <39837929+RWezeman@users.noreply.github.com>
Co-authored-by: RWezeman <39837929+RWezeman@users.noreply.github.com>
Co-authored-by: RWezeman <39837929+RWezeman@users.noreply.github.com>
Co-authored-by: RWezeman <39837929+RWezeman@users.noreply.github.com>
Owner
Author
|
thanks for your suggestions. Accepted all of them! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main contribution of this PR is the addition of two classes:
Court3DModelis a class that allows to map 3d world coordinates to 2d coordinates in the image space.KalmanFilter3DTrackingused to track in 3d the ball location.The Kalman filter also provides a method to estimate the initial location of a parabolic path, given its 2d image. Ideally, this estimate should be used upon initialization, but I have not addressed this for now.
Some additional changes:
requirements.txt