Skip to content

Implement filter#2

Open
amonras wants to merge 28 commits intomainfrom
implement_filter
Open

Implement filter#2
amonras wants to merge 28 commits intomainfrom
implement_filter

Conversation

@amonras
Copy link
Copy Markdown
Owner

@amonras amonras commented Oct 27, 2024

The main contribution of this PR is the addition of two classes:

  • Court3DModel is a class that allows to map 3d world coordinates to 2d coordinates in the image space.
  • KalmanFilter3DTracking used to track in 3d the ball location.
  • Some unit tests for the new classes, plus some test resources

The Kalman filter also provides a method to estimate the initial location of a parabolic path, given its 2d image. Ideally, this estimate should be used upon initialization, but I have not addressed this for now.

Some additional changes:

  • Pin versions in requirements.txt
  • Added some files to .gitignore
  • The Court model requires 14 keypoints to operate. With less, it will not work. Exception handling for this case has not been implemented.

Copy link
Copy Markdown

@RWezeman RWezeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool work. 3D detection seems not yet optimal but might have to play a bit more around with it.

Some suggestions I had to try to get your code to work

amonras and others added 5 commits January 24, 2025 10:27
Co-authored-by: RWezeman <39837929+RWezeman@users.noreply.github.com>
Co-authored-by: RWezeman <39837929+RWezeman@users.noreply.github.com>
Co-authored-by: RWezeman <39837929+RWezeman@users.noreply.github.com>
Co-authored-by: RWezeman <39837929+RWezeman@users.noreply.github.com>
Co-authored-by: RWezeman <39837929+RWezeman@users.noreply.github.com>
@amonras
Copy link
Copy Markdown
Owner Author

amonras commented Jan 24, 2025

thanks for your suggestions. Accepted all of them!

@amonras amonras marked this pull request as ready for review January 24, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants